get connection from pool to send digest auth response (#26733)

* get connection from pool to send digest auth response * fix incorrect comment. * s/TBD/TODO/
dotnet · Feb 2, 2018 · c727d12 · c727d12
1 parent 524f01c
commit c727d12
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/System.Net.Http/src/System/Net/Http/Managed/HttpProxyConnectionHandler.cs b/src/System.Net.Http/src/System/Net/Http/Managed/HttpProxyConnectionHandler.cs
@@ -88,6 +88,7 @@ private async Task<HttpResponseMessage> SendWithProxyAsync(
 
  if (credential != null)
  {
+ // TODO #23156: Drain response before disposing.
  response.Dispose();
 
  request.Headers.ProxyAuthorization = new AuthenticationHeaderValue(AuthenticationHelper.Basic,
@@ -111,8 +112,9 @@ private async Task<HttpResponseMessage> SendWithProxyAsync(
 
  if (await AuthenticationHelper.TrySetDigestAuthToken(request, credential, digestResponse, HttpKnownHeaderNames.ProxyAuthorization).ConfigureAwait(false))
  {
+ // TODO #23156: Drain response before disposing.
  response.Dispose();
- response = await _innerHandler.SendAsync(request, cancellationToken).ConfigureAwait(false);
+ response = await GetConnectionAndSendAsync(request, proxyUri, cancellationToken).ConfigureAwait(false);
 
  // Retry in case of nonce timeout in server.
  if (response.StatusCode == HttpStatusCode.ProxyAuthenticationRequired)