Catch the FileNotFoundException when to get the obsolete attribute fo…

…r type. (#27389) * Catch the FileNotFoundException when to get the obsolete attribute for type. * Move continue out of if. * Add some comments. * Update the comments.
dotnet · Feb 27, 2018 · edbe783 · edbe783
1 parent d9e55a9
commit edbe783
Showing 1 changed file with 24 additions and 10 deletions.
diff --git a/src/Microsoft.XmlSerializer.Generator/src/Sgen.cs b/src/Microsoft.XmlSerializer.Generator/src/Sgen.cs
@@ -232,23 +232,37 @@ private void GenerateFile(List<string> typeNames, string assemblyName, bool prox
             {
                 Type type = types[i];
 
-                if (type != null)
+                try
                 {
-                    bool isObsolete = false;
-                    object[] obsoleteAttributes = type.GetCustomAttributes(typeof(ObsoleteAttribute), false);
-                    foreach (object attribute in obsoleteAttributes)
+                    if (type != null)
                     {
-                        if (((ObsoleteAttribute)attribute).IsError)
+                        bool isObsolete = false;
+                        object[] obsoleteAttributes = type.GetCustomAttributes(typeof(ObsoleteAttribute), false);
+                        foreach (object attribute in obsoleteAttributes)
                         {
-                            isObsolete = true;
-                            break;
+                            if (((ObsoleteAttribute)attribute).IsError)
+                            {
+                                isObsolete = true;
+                                break;
+                            }
                         }
-                    }
 
-                    if (isObsolete)
+                        if (isObsolete)
+                        {
+                            continue;
+                        }
+                    }
+                }
+                //Ignore the FileNotFoundException when call GetCustomAttributes e.g. if the type uses the attributes defined in a different assembly
+                catch (FileNotFoundException e)
+                {
+                    if (warnings)
                     {
-                        continue;
+                        Console.Out.WriteLine(FormatMessage(parsableerrors, true, SR.Format(SR.InfoIgnoreType, type.FullName)));
+                        WriteWarning(e, parsableerrors);
                     }
+
+                    continue;
                 }
 
                 if (!proxyOnly)