Rename System.Transactions assembly in .NET Core

[weshaggard]

We cannot use the assembly name System.Transactions because that assembly already exist in the full .NET framework. We need to come up with another name and rename it before we try to ship this assembly.

[jimcarley]

I like System.Transactions.Local.

[weshaggard]

Sounds reasonable to me I tagged with api-ready-for-review to get other FXDC member opinions.

[stephentoub]

I like System.Transactions.Local

Does that suggest that any support for distributed transactions would be in another, higher-level assembly?

[jimcarley]

Yes. In my current vision for support of distributed transactions, we would add some abstract base classes to System.Transactions.Local and then have a new assembly, like System.Transactions.MSDTC, that will have implementations for those base classes along with the supporting code to talk to MSDTC on Windows. And somebody could write a separate assembly, like System.Transactions.DistributedOnLinux, that would use some other distributed transaction coordinator that runs on Linux. Without another assembly that has classes that derive from these new "distributed" abstract base classes in System.Transactions.Local, distributed transactions would not be supported, just like today.

[stephentoub]

Sounds good.

[karelz]

API review:
Order of preference - @jimcarley and team, please choose

1. System.Transactions.Ambient
2. System.Transactions.Local

[dmetzgar]

@karelz Our team is in agreement on System.Transactions.Local

[dmetzgar]

@weshaggard @karelz if we change the assembly name, does that also change the package name?

[karelz]

I don't think so - I let @weshaggard confirm for sure.

[weshaggard]

Just changing the assembly name will not update the package name but this name change does apply to both the package and the assembly so you should rename both of them.

[qizhanMS]

Previously we encountered version mismatch when we were trying to use the package. Do you think the version issue was gone?

[weshaggard]

@qizhanMS I need more information to help answer that question.

[karelz]

@qizhanMS is it fixed by dotnet/corefx#16444?

Note: You can use GitHub auto closing if you add "Fixes <issue_reference>" into your PR description.

[weshaggard]

Yes this is fixed by dotnet/corefx#16444