This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix WinHttpHandler for Basic auth with default credentials #11383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were getting an error "The parameter is incorrect" from WinHTTP when we tried to invoke default credential handling even for cases where the server doesn't use Negotiate or NTLM. Negotiate and NTLM are the only schemes that can use default credentials since they need to be transmitted via a challenge-response mechanism. The fix here is to only set WinHTTP default credentials handling for Negotiate or NTLM schemes. Otherwise, it should behave as-if there were no credentials set. Fixes #11266
Contributor
Author
|
Test Outerloop Windows_NT Debug please |
Contributor
Author
|
cc: @stephentoub @CIPop |
Member
|
LGTM |
Contributor
Author
|
Test Innerloop Ubuntu14.04 Debug Build and Test (Microsoft.Framework.WebEncoders.TextEncoderSettingsTests.ForbidRange) |
Contributor
Author
|
Test OuterLoop Ubuntu14.04 Release Build and Test (segmentation fault) |
Contributor
Author
|
Azure networking congestion for this CI run (""A task was canceled.") |
Contributor
Author
|
Test OuterLoop Ubuntu14.04 Release |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…tial Fix WinHttpHandler for Basic auth with default credentials Commit migrated from dotnet/corefx@c5c8afe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting an error "The parameter is incorrect" from WinHTTP when we tried to invoke default credential handling even for cases where the server doesn't use Negotiate or NTLM. Negotiate and NTLM are the only schemes that can use default credentials since they need to be transmitted via a challenge-response mechanism.
The fix here is to only set WinHTTP default credentials handling for Negotiate or NTLM schemes. Otherwise, it should behave as-if there were no credentials set.
Fixes #11266