This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Port System.Timers.Timer to netstandard1.7 #11760
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| <Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <Import Project="..\dir.props" /> | ||
| <PropertyGroup> | ||
| <AssemblyVersion>4.2.0.0</AssemblyVersion> | ||
| </PropertyGroup> | ||
| </Project> | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| // Stub to unblock explosing System.Timers | ||
|
|
||
| namespace System.ComponentModel | ||
| { | ||
| public partial interface ISynchronizeInvoke | ||
| { | ||
| IAsyncResult BeginInvoke(Delegate method, object[] args); | ||
| object EndInvoke(IAsyncResult result); | ||
| object Invoke(Delegate method, object[] args); | ||
| bool InvokeRequired { get; } | ||
| } | ||
|
|
||
| public partial interface ISupportInitialize | ||
| { | ||
| void BeginInit(); | ||
| void EndInit(); | ||
| } | ||
|
|
||
| public partial class Component : IDisposable | ||
| { | ||
| public Component() { } | ||
| public void Dispose() { } | ||
| protected virtual void Dispose(bool disposing) { } | ||
| ~Component() { } | ||
| protected virtual object GetService(Type service) { return default(object); } | ||
| public override string ToString() { return default(string); } | ||
| protected virtual bool CanRaiseEvents { get { return default(bool); } } | ||
| protected bool DesignMode { get { return default(bool); } } | ||
| public virtual ISite Site { get { return default(ISite); } set { } } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| namespace System.Timers | ||
| { | ||
| public class ElapsedEventArgs : EventArgs | ||
| { | ||
| private readonly DateTime _signalTime; | ||
|
|
||
| internal ElapsedEventArgs(long fileTime) | ||
| { | ||
| _signalTime = DateTime.FromFileTime(fileTime); | ||
| } | ||
|
|
||
| public DateTime SignalTime | ||
| { | ||
| get | ||
| { | ||
| return _signalTime; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| namespace System.Timers | ||
| { | ||
| public delegate void ElapsedEventHandler(object sender, ElapsedEventArgs e); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| // Stub to unblock explosing System.Timers Issue dotnet/corefx#11774 | ||
|
|
||
| namespace System.ComponentModel.Design | ||
| { | ||
| public partial interface IDesignerHost | ||
| { | ||
| IComponent RootComponent { get; } | ||
| } | ||
| } | ||
|
|
||
| namespace System.ComponentModel | ||
| { | ||
| public partial interface ISynchronizeInvoke | ||
| { | ||
| IAsyncResult BeginInvoke(Delegate method, object[] args); | ||
| object EndInvoke(IAsyncResult result); | ||
| object Invoke(Delegate method, object[] args); | ||
| bool InvokeRequired { get; } | ||
| } | ||
|
|
||
| public partial interface ISupportInitialize | ||
| { | ||
| void BeginInit(); | ||
| void EndInit(); | ||
| } | ||
|
|
||
| public partial class Component : IDisposable | ||
| { | ||
| public Component() { } | ||
| public void Dispose() { } | ||
|
Member
There was a problem hiding this comment. Dispose should invoke Dispose(true) and suppress finalization. |
||
| protected virtual void Dispose(bool disposing) { } | ||
| ~Component() { } | ||
| protected virtual object GetService(Type service) { return default(object); } | ||
| public override string ToString() { return default(string); } | ||
|
Member
There was a problem hiding this comment. ToString() should return base.ToString(). |
||
| protected virtual bool CanRaiseEvents { get { return default(bool); } } | ||
|
Member
There was a problem hiding this comment. Desktop returns true from this. Are we explicitly deciding to return false?
Contributor
Author
There was a problem hiding this comment. This class is not completely ported, i am just using it as a stub to get System.Timers unblocked. @AlexGhiondea is going to do the bulk porting of System.ComponentModel into a different assembly. Once his work is complete, we'll remove this.. Same for all concers in System.ComponentModel.cs, will add a comment and tracking bug. |
||
| protected bool DesignMode { get { return default(bool); } } | ||
|
Member
There was a problem hiding this comment. Nit: I realize it's the same thing, but this should probably be |
||
| public virtual ISite Site { get { return default(ISite); } set { } } | ||
|
|
||
|
Member
There was a problem hiding this comment. Doesn't Component have a Disposed event? |
||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably update these package versions to use the latest prerelease instead so that we are all compatible and have the right dependencies across ns1.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will address in a separate PR>