This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Reduce code size of Stack.Peek #12094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #12062, but for Stack. I had to add AggressiveInlining to get it to work, since it seems like the 1 extra byte from the
decin_size - 1was making it ineligible for inlining.Test code, before/after asm is available at the link. You can see inlining
Stack.Peekincreases the code size ofMainby 31 bytes, while inliningQueue.Peek(asm is in the previous PR) increases it by 30.cc @stephentoub, @ianhays