Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

S.R.CS.Unsafe add CopyBlockUnaligned and InitBlockAligned. Add UIntPtr overload to all copy and init-block methods. #12443

Merged
merged 1 commit into from
Oct 7, 2016

Conversation

nietras
Copy link

@nietras nietras commented Oct 7, 2016

Should close #12243, close dotnet/corefxlab#848

@jkotas @jamesqo @mellinoe @benaadams @mgravell

Please check tests and whether these seem ok, they are a bit redundant, of course.

…r overload to all copy and init-block methods.
@dnfclas
Copy link

dnfclas commented Oct 7, 2016

Hi @nietras, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Oct 7, 2016

@nietras, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you for the contribution!

@jkotas jkotas merged commit 563673a into dotnet:master Oct 7, 2016
@nietras nietras deleted the unsafe-block-unaligned branch October 7, 2016 13:54
@karelz karelz modified the milestone: 1.2.0 Dec 3, 2016
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Unsafe.CopyBlockUnaligned Alignment and 2 GiB overflow issues in Span<T>.TryCopyTo
4 participants