This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Span: Rename IsReferenceFree to IsReferenceOrContainsReferences #16093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename IsReferenceFree to IsReferenceOrContainsReferences for consistency with #14047 - Remove IsReferenceFreeCore micro-optimization that is actually hurting. This code runs just once and it is cheaper to do a check via reflection than to spend time in the JIT to optimize the extra code. - Re-enabled disables test
|
cc @ahsonkhan |
stephentoub
approved these changes
Feb 12, 2017
|
@dotnet-bot test Innerloop Windows_NT Debug Build and Test please |
karelz
changed the title
|
Has issue #14484 been resolved since the test is now enabled? I thought we were waiting on issue #13681. |
|
Yes, #14484 is resolved. I have closed it. It was blocked on GetItem implementation in fast span that was added recently. #13681 should still stay open. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…efx#16093) - Rename IsReferenceFree to IsReferenceOrContainsReferences for consistency with dotnet/corefx#14047 - Remove IsReferenceFreeCore micro-optimization that is actually hurting. This code runs just once and it is cheaper to do a check via reflection than to spend time in the JIT to optimize the extra code. - Re-enabled disables test Commit migrated from dotnet/corefx@73e25c0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is cheaper to do a check via reflection than to spend time in the JIT to optimize the extra code.