[release/1.1.0] Inbox value tuple

[ericstj]

Require buildtools update to build w/o validation errors.
dotnet/buildtools#1348

Fixes: #14235
/cc @jcouv @marek-safar @weshaggard

[jcouv]

ValueTuple is only inbox after a certain version on mono. Should the change be conditional on the version of mono?

[ericstj]

This doesn't apply for Mono, that behaves as desktop so its stuck getting the desktop binary.

Xamarin doesn't version their TFMs in a way that lets you target the framework API so those frameworks are stuck getting the behavior of the latest SDKs.

[ericstj]

Marking this as NO-MERGE since we need to wait for 1.1.0 to exit lock down and need to add the build-tools update. This is somewhat dependent on #16119 which does the boiler-plate work to version the ValueTuple package for servicing.

[ericstj]

Now that #16119 is not going in we need to bring over the versioning changes to this PR.

[ericstj]

Brought those commits over. I expect this to fail during package validation until we can get dotnet/buildtools#1348

[ericstj]

This is ready to go, @jcouv and @marek-safar can you guys please try "System.ValueTuple": "4.3.1-servicing-25101-0" from feed https://www.myget.org/F/ericstj-staging/api/v3/index.json?

[jcouv]

I've run the tests from ValueTupleTests.cs against the package in a .Net Framework 2.0 project (with XUnit 1.9). I think that covers the PCL portion of the package.

I'm now trying to do the same with the .Net Standard portion of the package. But I'm having trouble getting XUnit to work on .Net Standard 1.0 or 1.1. I'll keep you posted.

[ericstj]

@marek-safar / @mhutch / @akoeplinger can one of you ack this and do whatever testing you need to make sure it satisfies your ask? Given this fix is specifically for Xamarin TFMs I want to make sure it gets tested there.

[jcouv]

Thanks for the tips @ericstj
I've successfully run all the tests from ValueTupleTests.cs in a .Net Standard 1.0 project as well.

[jcouv]

@marek-safar / @mhutch / @akoeplinger Can you validate the change with mono? Thanks in advance.

[marek-safar]

@ericstj @jcouv I can confirm that this package works as expected (no compiler errors when System.ValueTuple is used) on Xamarin dev15-2

[stephentoub]

@ericstj, can this be merged now?

[ericstj]

Let me double check with ship-room on that. We had early approval before the buildtools changes went in I just want an ACK that we're OK to merge.

[ericstj]

We have the green light. Merging