Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

LINQ ToArray, ToList, ToDictionary unit tests #1692

Merged

Conversation

ikopylov
Copy link
Contributor

Unit tests for ToArray, ToList and ToDictionary methods from System.Linq. This PR is a part of work on #1182 issue.

@stephentoub
Copy link
Member

cc: @VSadov


namespace System.Linq.Tests
{
public class ToArrayToListToDictionaryTests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this into multiple classes/files, one per each of the To* methods?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests use the same set of helper classes. So it will require to put helper classes in separate files too. Is it OK?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I'll split them.

@stephentoub
Copy link
Member

@dotnet-bot test this please

@VSadov
Copy link
Member

VSadov commented May 11, 2015

LGTM

stephentoub added a commit that referenced this pull request May 11, 2015
…ry_tests

LINQ ToArray, ToList, ToDictionary unit tests
@stephentoub stephentoub merged commit a746248 into dotnet:master May 11, 2015
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…st_toDictionary_tests

LINQ ToArray, ToList, ToDictionary unit tests

Commit migrated from dotnet/corefx@a746248
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants