-
Notifications
You must be signed in to change notification settings - Fork 4.9k
LINQ ToArray, ToList, ToDictionary unit tests #1692
LINQ ToArray, ToList, ToDictionary unit tests #1692
Conversation
cc: @VSadov |
|
||
namespace System.Linq.Tests | ||
{ | ||
public class ToArrayToListToDictionaryTests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we split this into multiple classes/files, one per each of the To* methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests use the same set of helper classes. So it will require to put helper classes in separate files too. Is it OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I'll split them.
@dotnet-bot test this please |
LGTM |
…ry_tests LINQ ToArray, ToList, ToDictionary unit tests
…st_toDictionary_tests LINQ ToArray, ToList, ToDictionary unit tests Commit migrated from dotnet/corefx@a746248
Unit tests for
ToArray
,ToList
andToDictionary
methods fromSystem.Linq
. This PR is a part of work on #1182 issue.