Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Port 2.0: Prep tests for CoreCLR/CoreRT [Serializable] cleanup (#20035) #20210

Closed

Conversation

morganbr
Copy link

2.0 port of #20035 Fixes tests that depend on types in System.Private.CoreLib being serializable that won't be serializable soon.

Fixes https://github.com/dotnet/corefx/issues/20041.

Fixes tests that depend on types in System.Private.CoreLib being serializable that won't be serializable soon.
@morganbr
Copy link
Author

CC @danmosemsft @tarekgh @dotnet/corert-contrib

@morganbr morganbr self-assigned this May 24, 2017
@morganbr morganbr added this to the 2.0.0 milestone May 24, 2017
@tarekgh
Copy link
Member

tarekgh commented May 24, 2017

LGTM. Thanks @morganbr

@danmoseley danmoseley added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label May 24, 2017
@danmoseley
Copy link
Member

Let's gather all changes and talk to shiproom before merging.

@karelz karelz added area-Serialization blocked Issue/PR is blocked on something - see comments area-Meta and removed area-Serialization labels May 24, 2017
@tarekgh
Copy link
Member

tarekgh commented May 24, 2017

Let's gather all changes and talk to shiproom before merging.

Is this will be done through the email or there is scheduled meeting for it?

@danmoseley
Copy link
Member

Is this will be done through the email or there is scheduled meeting for it?

We are doing shiproom by email this week. We may end up going to shiproom physically on Thursday given the size of the change. We will have to explain that we will need to synchronize changes back and forth between coreclr and corefx which may take a couple days.

@tarekgh
Copy link
Member

tarekgh commented May 25, 2017

@danmosemsft any update regarding the shiproom?

@danmoseley
Copy link
Member

@tarekgh I have a conflict, but I'll send an update mail beforehand. Clearly we can't take it today.

@danmoseley
Copy link
Member

@morganbr I guess this is defunct?

@morganbr
Copy link
Author

morganbr commented Jun 1, 2017

@danmosemsft yep. I'll close it out.

@morganbr morganbr closed this Jun 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Meta blocked Issue/PR is blocked on something - see comments * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants