Port HttpListener fix for disconnect while reading request body

[geoffkizer]

Merge fix #20428

@stephentoub

[stephentoub]

@geoffkizer, FYI, one HttpListener test failed, though I don't know if it's related to your change:

System.Net.Tests.HttpListenerResponseHeadersTests.StatusCode_SetAndSend_Success(statusCode: 999, startLine: \"HTTP/1.1 999 \", expectedNumberOfBytes: 118) [FAIL]
        System.Net.Internals.SocketExceptionFactory+ExtendedSocketException : Connection refused 127.0.0.1:1168
        Stack Trace:
           /Users/dotnet-bot/j/workspace/dotnet_corefx/release_2.0.0/osx10.12_release_prtest/src/System.Net.Sockets/src/System/Net/Sockets/Socket.cs(4529,0): at System.Net.Sockets.Socket.DoConnect(EndPoint endPointSnapshot, SocketAddress socketAddress)
           /Users/dotnet-bot/j/workspace/dotnet_corefx/release_2.0.0/osx10.12_release_prtest/src/System.Net.Sockets/src/System/Net/Sockets/Socket.cs(825,0): at System.Net.Sockets.Socket.Connect(EndPoint remoteEP)
           /Users/dotnet-bot/j/workspace/dotnet_corefx/release_2.0.0/osx10.12_release_prtest/src/System.Net.Sockets/src/System/Net/Sockets/Socket.cs(930,0): at System.Net.Sockets.Socket.Connect(IPAddress[] addresses, Int32 port)
           --- End of stack trace from previous location where exception was thrown ---
              at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           /Users/dotnet-bot/j/workspace/dotnet_corefx/release_2.0.0/osx10.12_release_prtest/src/System.Net.Sockets/src/System/Net/Sockets/Socket.cs(940,0): at System.Net.Sockets.Socket.Connect(IPAddress[] addresses, Int32 port)
           /Users/dotnet-bot/j/workspace/dotnet_corefx/release_2.0.0/osx10.12_release_prtest/src/System.Net.Sockets/src/System/Net/Sockets/Socket.cs(889,0): at System.Net.Sockets.Socket.Connect(String host, Int32 port)
           /Users/dotnet-bot/j/workspace/dotnet_corefx/release_2.0.0/osx10.12_release_prtest/src/System.Net.HttpListener/tests/HttpListenerFactory.cs(150,0): at System.Net.Tests.HttpListenerFactory.GetConnectedSocket()
           /Users/dotnet-bot/j/workspace/dotnet_corefx/release_2.0.0/osx10.12_release_prtest/src/System.Net.HttpListener/tests/HttpListenerResponseTests.cs(21,0): at System.Net.Tests.HttpListenerResponseTestBase..ctor()
              at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean skipCheckThis, Boolean fillCache, StackCrawlMark& stackMark)

The tizen leg failure is entirely unrelated, just infrastructure.

[geoffkizer]

The OSX failure looks strangely similar to the connection pooling issue we're talking about. I doubt it's related to my change. Will rerun.

[geoffkizer]

@dotnet-bot test Innerloop OSX10.12 Release x64

[geoffkizer]

@dotnet-bot help

[dotnet-bot]

Welcome to the dotnet/corefx Repository

The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR

The following commands are valid for all PRs and repositories.

Click to expand

Comment Phrase	Action
@dotnet-bot test this please	Re-run all legs. Use sparingly
@dotnet-bot test ci please	Generates (but does not run) jobs based on changes to the groovy job definitions in this branch
@dotnet-bot help	Print this help message

The following jobs are launched by default for each PR against dotnet/corefx:release/2.0.0.

Click to expand

Comment Phrase	Job Launched
@dotnet-bot test Windows_NT Debug AllConfigurations Build	Windows_NT Debug AllConfigurations Build
@dotnet-bot test Innerloop CentOS7.1 Debug x64 Build and Test	Innerloop CentOS7.1 Debug x64 Build and Test
@dotnet-bot test Innerloop CentOS7.1 Release x64 Build and Test	Innerloop CentOS7.1 Release x64 Build and Test
@dotnet-bot test Innerloop netfx Windows_NT Debug x86 Build and Test	Innerloop netfx Windows_NT Debug x86 Build and Test
@dotnet-bot test Innerloop netfx Windows_NT Release x64 Build and Test	Innerloop netfx Windows_NT Release x64 Build and Test
@dotnet-bot test Innerloop OSX10.12 Debug x64 Build and Test	Innerloop OSX10.12 Debug x64 Build and Test
@dotnet-bot test Innerloop OSX10.12 Release x64 Build and Test	Innerloop OSX10.12 Release x64 Build and Test
@dotnet-bot test Innerloop PortableLinux Debug x64 Build and Test	Innerloop PortableLinux Debug x64 Build and Test
@dotnet-bot test Innerloop PortableLinux Release x64 Build and Test	Innerloop PortableLinux Release x64 Build and Test
@dotnet-bot test Innerloop Tizen armel Debug Cross Build	Innerloop Tizen armel Debug Cross Build
@dotnet-bot test Innerloop Tizen armel Release Cross Build	Innerloop Tizen armel Release Cross Build
@dotnet-bot test Vertical uap Build	Vertical uap Build
@dotnet-bot test Vertical uapaot Build	Vertical uapaot Build
@dotnet-bot test Innerloop Ubuntu14.04 arm Release Cross Build	Innerloop Ubuntu14.04 arm Release Cross Build
@dotnet-bot test Innerloop Ubuntu14.04 Debug x64 Build and Test	Innerloop Ubuntu14.04 Debug x64 Build and Test
@dotnet-bot test Innerloop Ubuntu14.04 Release x64 Build and Test	Innerloop Ubuntu14.04 Release x64 Build and Test
@dotnet-bot test Innerloop Ubuntu16.04 arm Debug Cross Build	Innerloop Ubuntu16.04 arm Debug Cross Build
@dotnet-bot test Innerloop Windows_NT Debug x86 Build and Test	Innerloop Windows_NT Debug x86 Build and Test
@dotnet-bot test Innerloop Windows_NT Release x64 Build and Test	Innerloop Windows_NT Release x64 Build and Test

The following optional jobs are available in PRs against dotnet/corefx:release/2.0.0.

Click to expand

Comment Phrase	Job Launched
@dotnet-bot test code coverage	Queues Code Coverage Windows Debug
@dotnet-bot test innerloop Debian8.4 Debug	Queues Innerloop Debian8.4 Debug x64 Build and Test
@dotnet-bot test innerloop Debian8.4 Release	Queues Innerloop Debian8.4 Release x64 Build and Test
@dotnet-bot test innerloop Fedora24 Debug	Queues Innerloop Fedora24 Debug x64 Build and Test
@dotnet-bot test innerloop Fedora24 Release	Queues Innerloop Fedora24 Release x64 Build and Test
@dotnet-bot test code formatter check	Queues Code Formatter Check
@dotnet-bot test innerloop OpenSUSE13.2 Debug	Queues Innerloop OpenSUSE13.2 Debug x64 Build and Test
@dotnet-bot test innerloop OpenSUSE13.2 Release	Queues Innerloop OpenSUSE13.2 Release x64 Build and Test
@dotnet-bot test innerloop OpenSUSE42.1 Debug	Queues Innerloop OpenSUSE42.1 Debug x64 Build and Test
@dotnet-bot test innerloop OpenSUSE42.1 Release	Queues Innerloop OpenSUSE42.1 Release x64 Build and Test
@dotnet-bot test outerloop netcoreapp CentOS7.1 Debug	Queues OuterLoop netcoreapp CentOS7.1 Debug x64
@dotnet-bot test outerloop netcoreapp CentOS7.1 Release	Queues OuterLoop netcoreapp CentOS7.1 Release x64
@dotnet-bot test outerloop netcoreapp Debian8.4 Debug	Queues OuterLoop netcoreapp Debian8.4 Debug x64
@dotnet-bot test outerloop netcoreapp Debian8.4 Release	Queues OuterLoop netcoreapp Debian8.4 Release x64
@dotnet-bot test outerloop netcoreapp Fedora24 Debug	Queues OuterLoop netcoreapp Fedora24 Debug x64
@dotnet-bot test outerloop netcoreapp Fedora24 Release	Queues OuterLoop netcoreapp Fedora24 Release x64
@dotnet-bot test outerloop netcoreapp OpenSUSE13.2 Debug	Queues OuterLoop netcoreapp OpenSUSE13.2 Debug x64
@dotnet-bot test outerloop netcoreapp OpenSUSE13.2 Release	Queues OuterLoop netcoreapp OpenSUSE13.2 Release x64
@dotnet-bot test outerloop netcoreapp OpenSUSE42.1 Debug	Queues OuterLoop netcoreapp OpenSUSE42.1 Debug x64
@dotnet-bot test outerloop netcoreapp OpenSUSE42.1 Release	Queues OuterLoop netcoreapp OpenSUSE42.1 Release x64
@dotnet-bot test outerloop netcoreapp OSX10.12 Debug	Queues OuterLoop netcoreapp OSX10.12 Debug x64
@dotnet-bot test outerloop netcoreapp OSX10.12 Release	Queues OuterLoop netcoreapp OSX10.12 Release x64
@dotnet-bot test outerloop netcoreapp PortableLinux Debug	Queues OuterLoop netcoreapp PortableLinux Debug x64
@dotnet-bot test outerloop netcoreapp PortableLinux Release	Queues OuterLoop netcoreapp PortableLinux Release x64
@dotnet-bot test outerloop netcoreapp RHEL7.2 Debug	Queues OuterLoop netcoreapp RHEL7.2 Debug x64
@dotnet-bot test outerloop netcoreapp RHEL7.2 Release	Queues OuterLoop netcoreapp RHEL7.2 Release x64
@dotnet-bot test outerloop netcoreapp Ubuntu14.04 Debug	Queues OuterLoop netcoreapp Ubuntu14.04 Debug x64
@dotnet-bot test outerloop netcoreapp Ubuntu14.04 Release	Queues OuterLoop netcoreapp Ubuntu14.04 Release x64
@dotnet-bot test outerloop netcoreapp Ubuntu16.04 Debug	Queues OuterLoop netcoreapp Ubuntu16.04 Debug x64
@dotnet-bot test outerloop netcoreapp Ubuntu16.04 Release	Queues OuterLoop netcoreapp Ubuntu16.04 Release x64
@dotnet-bot test outerloop netcoreapp Ubuntu16.10 Debug	Queues OuterLoop netcoreapp Ubuntu16.10 Debug x64
@dotnet-bot test outerloop netcoreapp Ubuntu16.10 Release	Queues OuterLoop netcoreapp Ubuntu16.10 Release x64
@dotnet-bot test outerloop netcoreapp Windows 10 Debug	Queues OuterLoop netcoreapp Windows 10 Debug x64
@dotnet-bot test outerloop netcoreapp Windows 10 Release	Queues OuterLoop netcoreapp Windows 10 Release x64
@dotnet-bot test outerloop netcoreapp Windows 7 Debug	Queues OuterLoop netcoreapp Windows 7 Debug x64
@dotnet-bot test outerloop netcoreapp Windows 7 Release	Queues OuterLoop netcoreapp Windows 7 Release x64
@dotnet-bot test outerloop netcoreapp Windows_NT Debug	Queues OuterLoop netcoreapp Windows_NT Debug x64
@dotnet-bot test outerloop netcoreapp Windows_NT Release	Queues OuterLoop netcoreapp Windows_NT Release x64
@dotnet-bot test outerloop netfx Windows_NT Debug	Queues OuterLoop netfx Windows_NT Debug x64
@dotnet-bot test outerloop netfx Windows_NT Release	Queues OuterLoop netfx Windows_NT Release x64
@dotnet-bot test outerloop Windows Nano 2016 Debug	Queues OuterLoop Windows Nano 2016 Debug
@dotnet-bot test outerloop Windows Nano 2016 Release	Queues OuterLoop Windows Nano 2016 Release
@dotnet-bot test innerloop RHEL7.2 Debug	Queues Innerloop RHEL7.2 Debug x64 Build and Test
@dotnet-bot test innerloop RHEL7.2 Release	Queues Innerloop RHEL7.2 Release x64 Build and Test
@dotnet-bot test innerloop Ubuntu14.04 arm Debug	Queues Innerloop Ubuntu14.04 arm Debug Cross Build
@dotnet-bot test innerloop Ubuntu16.04 arm Release	Queues Innerloop Ubuntu16.04 arm Release Cross Build
@dotnet-bot test innerloop Ubuntu16.04 Debug	Queues Innerloop Ubuntu16.04 Debug x64 Build and Test
@dotnet-bot test innerloop Ubuntu16.04 Release	Queues Innerloop Ubuntu16.04 Release x64 Build and Test
@dotnet-bot test innerloop Ubuntu16.10 Debug	Queues Innerloop Ubuntu16.10 Debug x64 Build and Test
@dotnet-bot test innerloop Ubuntu16.10 Release	Queues Innerloop Ubuntu16.10 Release x64 Build and Test

Have a nice day!

[geoffkizer]

@dotnet-bot test Innerloop OSX10.12 Release x64 Build and Test