This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix cryptography errors on macOS 10.13 #21631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is causing a segfault to occur somewhere in the Security.framework SecTrust code. While that's being investigated, disable the test, so we can get results from the rest of the tests.
danmoseley
reviewed
Jun 27, 2017
| @@ -165,6 +165,8 @@ public static void TestDispose() | |||
| } | |||
|
|
|||
| [Fact] | |||
| // Crashing on macOS 10.13 Beta | |||
There was a problem hiding this comment.
if we start doing this more, we can add a version detection method to PlatformDetectin.
stephentoub
approved these changes
Jun 27, 2017
|
Will this fix the X509 issues, which have different symptoms? https://github.com/dotnet/corefx/issues/21436 |
ianhays
approved these changes
Jun 27, 2017
This was referenced Jun 29, 2017
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Address kCCUnimplemented in CCCryptoReset for ECB * Ignore new `StatusCodes` value in chain trust results. * Disable X509Chain `TestResetMethod` test on macOS The test is causing a segfault to occur somewhere in the Security.framework SecTrust code. While that's being investigated, disable the test, so we can get results from the rest of the tests. Commit migrated from dotnet/corefx@e48ef36
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a long-term workaround for the behavior change in CCCryptorReset for ECB transforms (should the workaround be inadequate we'd catch it in testing at a future point... but since ECB is stateless it's fine).
It provides a stable workaround for the appearance of a new status info field in the trust results. Unless "StatusCodes" became used to represent some new type of distinct error at a later date it seems ignorable.
The TestResetMethod chain test is being disabled because it's segfaulting. It appears to be the sole test testing DSA-based certificate chains, which might indicate a DSA-based regression in the new OS version. Investigation will continue.