This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix test assertions for long paths #22393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't preemptively check path length any more. The OS errors we get back can either be PathTooLong or NotFound depending on the environment and requested path.
danmoseley
approved these changes
Jul 18, 2017
Member
|
I assume we already determined we are ok with the breaking change. |
Member
Author
Yes, our baselines just missed these cases. |
joperezr
approved these changes
Jul 18, 2017
pjanotti
pushed a commit
to pjanotti/corefx
that referenced
this pull request
Jul 20, 2017
We don't preemptively check path length any more. The OS errors we get back can either be PathTooLong or NotFound depending on the environment and requested path.
Contributor
|
Refer to #8655 for background on changes. |
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Feb 5, 2019
* Add explanation comment Fixes dotnet#22393 Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
that referenced
this pull request
Feb 5, 2019
* Add explanation comment Fixes #22393 Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
We don't preemptively check path length any more. The OS errors we get back can either be PathTooLong or NotFound depending on the environment and requested path. Commit migrated from dotnet/corefx@65ba208
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't preemptively check path length any more. The OS errors we
get back can either be PathTooLong or NotFound depending on the
environment and requested path.
See #22368