Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Expose/test TimeSpan span-based methods #23594

Merged
merged 2 commits into from
Sep 8, 2017
Merged

Expose/test TimeSpan span-based methods #23594

merged 2 commits into from
Sep 8, 2017

Conversation

stephentoub
Copy link
Member

Two commits:

  1. Adds a bunch of test validation, which all passes on the existing implementation. This boosts code coverage up to ~95% line and ~91% branch coverage for TimeSpan's parsing code.
  2. Exposes the new span-based TimeSpan.{Try}Parse{Exact} and TryFormat methods and adds tests for them (largely copies of the existing string-based tests).

Depends on dotnet/coreclr#13619
Closes https://github.com/dotnet/corefx/issues/22375
cc: @AlexGhiondea, @joperezr, @tarekgh

@stephentoub
Add more TimeSpan tests
04a73e6 
Based on code coverage analysis, adds tests for additional cases not covered.  Brings line coverage for TimeSpanParse up to 95.1% line and 91.3% branch.
@stephentoub
Expose and add tests for TimeSpan span-based methods
368f4d7
tarekgh
tarekgh approved these changes Aug 28, 2017
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

joperezr
joperezr approved these changes Sep 1, 2017
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding these Steve.

@stephentoub
Copy link
Member Author

@dotnet-bot test this please

@stephentoub stephentoub merged commit 41d1d77 into dotnet:master Sep 8, 2017
@stephentoub stephentoub deleted the timespan_span branch September 8, 2017 13:38
@karelz karelz added this to the 2.1.0 milestone Oct 11, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@stephentoub
Merge pull request dotnet/corefx#23594 from stephentoub/timespan_span
c3b702d 
Expose/test TimeSpan span-based methods

Commit migrated from dotnet/corefx@41d1d77
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

@joperezr joperezr joperezr approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Runtime
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@stephentoub @tarekgh @joperezr @karelz @dnfclas