Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Correct row source field is used to get column ordinal. #24655

Merged
merged 1 commit into from
Nov 5, 2017
Merged

Correct row source field is used to get column ordinal. #24655

merged 1 commit into from
Nov 5, 2017

Conversation

satano
Copy link
Member

@satano satano commented Oct 15, 2017

Current version uses _DbDataReaderRowSource field. This field is null in case of own implementation of IDataReader, which is not inherited from DbDataReader.

Fixes #24638

@saurabh500
Copy link
Contributor

@satano did you take this fix from the framework source?

@satano
Copy link
Member Author

satano commented Nov 5, 2017

@saurabh500 I just checked it there after. But now I see, it is casted tere to IDataRecord, not IDataReader. So maybe I should also cast to IDataRecord. But anyway, casting to IDataReader should not be a problem, because from outside only IDataReader can be passed as data source.

What do you think?

@saurabh500 saurabh500 merged commit 552ef49 into dotnet:master Nov 5, 2017
@saurabh500
Copy link
Contributor

@satano Looks good to me.

@satano
Copy link
Member Author

satano commented Nov 5, 2017

@saurabh500 The issue #24871 should be closed too. It is a duplicate of original issue (#24638) from which this PR arose.

@satano satano deleted the issues/24638-NreInSqlBulkCopy branch November 5, 2017 19:51
JulienVicini pushed a commit to JulienVicini/QueryBuilder that referenced this pull request Mar 11, 2018
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants