Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

revert part of #24098. do not use shell to find KDestroyCmd. #24682

Merged
merged 1 commit into from
Oct 18, 2017
Merged

revert part of #24098. do not use shell to find KDestroyCmd. #24682

merged 1 commit into from
Oct 18, 2017

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Oct 17, 2017

@dotnet-bot test outerloop netcoreapp Ubuntu17.10 Release
@dotnet-bot test outerloop netcoreapp Ubuntu17.04 Release
@dotnet-bot test outerloop netcoreapp Centos7 Release

@wfurt
Copy link
Member Author

wfurt commented Oct 17, 2017

@dotnet-bot test this please

stephentoub
stephentoub reviewed Oct 17, 2017
View reviewed changes
src/System.Net.Security/tests/FunctionalTests/NegotiateStreamTestForUnix.cs
PlatformDetection.IsOpenSUSE ||
PlatformDetection.IsFedora ||
PlatformDetection.IsDebian ||
PlatformDetection.IsCentos7);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure @stephentoub I was hoping that dotnet-bot would tell me. Since all this was introduced at the same time, I'm assuming that root cause is same e.g. we broke process.Start with shell flag.

@wfurt wfurt requested a review from danmoseley October 17, 2017 15:51
@wfurt wfurt changed the title [WIP] revert part of #24098. do not use shell to find KDestroyCmd. revert part of #24098. do not use shell to find KDestroyCmd. Oct 17, 2017
@wfurt
Copy link
Member Author

wfurt commented Oct 17, 2017

fixes #24000 All Linux platforms passed tests.

@stephentoub
Copy link
Member

All Linux platforms passed tests

Did you run Outerloop?

@wfurt
Copy link
Member Author

wfurt commented Oct 18, 2017

Is there some easy way to tell? The stats show:

Pass: 4,170,536 Skip: 14,646
Documentation for 'dotnet-bot test this please' said it would run all CI legs.

@dotnet-bot test outerloop netcoreapp RedHat.73.Amd64

@stephentoub
Copy link
Member

Documentation ... said it would run all CI legs.

It runs (re-runs) all of the legs associated with a PR by default. That does not include any outerloop runs.

@stephentoub
Copy link
Member

@dotnet-bot test Outerloop Linux x64 Debug Build please

@danmoseley
Copy link
Member

Thanks @wfurt

@danmoseley danmoseley merged commit f757a32 into dotnet:master Oct 18, 2017
@karelz karelz added this to the 2.1.0 milestone Oct 28, 2017
pjanotti pushed a commit to pjanotti/corefx that referenced this pull request Oct 31, 2017
@wfurt
revert part of dotnet#24098. do not use shell to find KDestroyCmd. (d…
61bb65e 
…otnet#24682)
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@wfurt @danmoseley
revert part of dotnet/corefx#24098. do not use shell to find KDestroy…
1de723e 
…Cmd. (dotnet/corefx#24682)

Commit migrated from dotnet/corefx@f757a32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@danmoseley danmoseley Awaiting requested review from danmoseley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wfurt @stephentoub @danmoseley @karelz @dnfclas