Add System.Management #24719

pjanotti · 2017-10-18T15:08:20Z

Bringing System.Management, a.k.a WMI, as a CoreFX package that can run on Windows.

I am hitting issues in Unix with generated assemblies: CA1821 empty finalizers, I will investigate the options here, it can't be pushed as it is.

I still have to validate build on uap and uapaot.

After this initial commit more tests and code clean up and formatting are still going to be added/done the main focus here is to get projects/build correctly set up.

Fixes #14762

Opportunistic: some small changes related to warnings

Also moved so DllImport to use Common version of files.

Code builds and pass single test

This allows methods to generate CodeDom for strong type access to WMI objects.

The finalizers are being generated empty for PNSE assembly. In such cases disable CA1821.

tarekgh · 2017-10-18T16:37:48Z

I left some comments mostly about the code formatting. did we run the formatter tool on the introduced source files?

pjanotti · 2017-10-18T17:00:49Z

No, I didn't run the code formatter. There was some discussion to not run it against this code but after first commit do the VS ones (e.g.: rename fields, etc).

pjanotti · 2017-10-18T17:02:54Z

My main concern at this moment is with the projects/build related stuff.

tarekgh · 2017-10-18T17:04:05Z

but after first commit do the VS ones (e.g.: rename fields, etc).

We should be careful renaming the fields as I am seeing the classes support serialization. So if we need to be compatible with the desktop serialization, we’ll need to keep the same field names.

pjanotti · 2017-10-18T17:27:49Z

Thanks @tarekgh! I wasn't thinking about serialization, will have to look before doing anything.

joperezr · 2017-10-18T17:59:20Z

src/Common/src/System/SR.cs

NIT: we can undo this change 😄

That was automatically made by some tool 😄 I will undo it.

joperezr · 2017-10-18T18:01:24Z

src/System.Management/pkg/System.Management.pkgproj

+      <SupportedFramework>netcoreapp2.0</SupportedFramework>
+    </ProjectReference>
+    <ProjectReference Include="..\src\System.Management.csproj" />
+    <InboxOnTargetFramework Include="net45">


I would have expected the package index to also contain a change about this new library and where is it inboxed.

Ops forgot that, also what is the correct version? the smallest possible?

do you mean the assembly version? If so, we should use whatever is on desktop.

There was already an entry for System.Management in the packages index, but now with the other changes of build configurations, I've been unable to get a clean local build (yet).

pjanotti · 2017-10-21T15:40:11Z

@danmosemsft @joperezr per conversation yesterday with @weshaggard this one should not have a facade, since it has a module with same name on desktop, so I went back to initial format. Please, take a look at the current changes (Linux failures are unrelated).

4creators · 2017-10-21T16:01:26Z

This PR is related to API discussion from issue https://github.com/dotnet/corefx/issues/22660 Since Linux is slowly growing support for CIM and WMI infrastructure it would be very interesting to exploit possibilities which this creates for support of System.Management on Linux. See Windows Management Instrumentation Now A Formal Bus With Linux 4.13

danmoseley · 2017-10-25T00:44:25Z

src/System.Management/pkg/System.Management.pkgproj

@@ -3,7 +3,7 @@
  <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" />
  <ItemGroup>
    <ProjectReference Include="..\ref\System.Management.csproj">
-      <SupportedFramework>netcoreapp2.0;net45;$(AllXamarinFrameworks)</SupportedFramework>
+      <SupportedFramework>netcoreapp2.0;net45;$(UAPvNextTFM);$(AllXamarinFrameworks)</SupportedFramework>


Do we need this in other libraries? Only 5 libraries already have it.

And System.Drawing.Common.pkproj eg doesn't have net45/net461 either:
<SupportedFramework>netcoreapp2.0</SupportedFramework>

@safern I wonder if all these need regularizing as well.

System.Drawing.Common.pkproj eg doesn't have net45/net461 either.

I'm adding net461 into System.Drawing.Common and also AllXamarinFrameworks in a PR I have open.

UAPvNextTFM I don't think we need it since it will already be netstandard.

Yes, this need regularizing as well from the quick look I just took. I can work with @pjanotti offline to get it according to what we have in the other projects.

Per my conversation with Tarek that is my understanding: this needs regularizing.

UAPvNextTFM was added at this moment while adding the PNS assembly for uap, otherwise we hit: "System.Management should not be supported on UAP,Version=v10.0.15138/win10-x86 but has runtime assets "

Alternatively we can keep it closer to System.DirectoryServices.AccountManagement that doesn't have a PNS assembly for uap yet.

That said I want to make this initial commit soon so I can focus more on the test coverage and the sources themselves, so far I've been most of the time dealing with build/packaging issues.

Maybe the UapVNextTFM is then needed. However we need netfx facades also. You can merge as is and I can revisit and fix the configurations if you want. But fixing them wouldn’t take us more than 1 hour.

You can take this PR as an example: #24758

pjanotti · 2017-10-25T15:41:56Z

I am merging this change so we get a separate commit for the "regularizing" step.

@weshaggard

* First pass building * Remove Instrumentation and WMIGenerator * Resources to as used on CoreFX Opportunistic: some small changes related to warnings * Removed hard coded path to load wminet_utils Also moved so DllImport to use Common version of files. * Added ref, sln, and single basic test Code builds and pass single test * Add CoreFX source header * Removing unused using directives * clean src proj references * A bit more test coverage (19%) * Sanitizer pass with default settings * Adding WMIGenerator This allows methods to generate CodeDom for strong type access to WMI objects. * Missing files from previous commit * Some extra clean-up missed by SSS * Removing #ifdef dead code * Add pkg project * Removing more dead code * Removing dead code and small improvement to tests * Suppress CA1821 when generating PNSE assembly The finalizers are being generated empty for PNSE assembly. In such cases disable CA1821. * Source changes from CR (so far) * Targets and package issues * Go back to project targets and settings Per conversation w/ @weshaggard it should follow the same model as System.DirectoryServices not the packages of dlls that do not exist on desktop. This still is not expected to be fully correct but it puts the projects closer to the targets that they will have in the end. * Description for the System.Management package. * Match supported pkg frameworks * Skip tests on Windows Nano * Missed files from previous commit * Untabify files and a bit more tests * Generate PNS Assembly for uap * Add references needed by uap for PNS assembly * PNS assembly message * Fixing package issue

jianxuanbing · 2017-11-16T15:48:14Z

Hello,I have a questin.I use examples

ManagementClass diskClass = new ManagementClass("Win32_LogicalDisk");
diskClass.Get();
Output.WriteLine("Logical Disk class has " + diskClass.Properties.Count + " properties");

but is not ok,throw exception

System.TypeInitializationException : The type initializer for 'System.Management.WmiNetUtilsHelper' threw an exception.
---- System.NullReferenceException : Object reference not set to an instance of an object.
   at System.Management.MTAHelper.IsNoContextMTA()
   at System.Management.MTAHelper.CreateInMTA(Type type)
   at System.Management.ManagementPath.CreateWbemPath(String path)
   at System.Management.ManagementClass..ctor(String path)

pjanotti · 2017-11-16T18:02:23Z

Hi, thanks for reporting it. I can't repro the issue. Please, provide the details and a small repro - feel free to open a separate issue with those details.

Notice that System.Management namespace is intended for legacy code only.

jianxuanbing · 2017-11-17T01:16:38Z

Hi,I changed the compter,the result is normal.
I will try again.

jianxuanbing · 2017-11-19T14:20:23Z

I use the same code. But at home when the computer tests is throw Exception.
But at company when the computer tests is ok.

        public static string GetName()
        {
            using (ManagementClass mc = new ManagementClass(WmiPathConst.Processor))
            {
                ManagementObjectCollection moc = mc.GetInstances();
                return moc.OfType<ManagementObject>()
                    .Select(mo => mo[ManagementObjectConst.Name].ToString())
                    .FirstOrDefault();
            }
        }

STRATZ-Ken · 2017-12-22T21:36:28Z

Same issue as @jianxuanbing except I am trying for the NetworkAdapaters.

I am running it on Windows 2012 R2 in a Hyper-V VM in 64 Bit. If any of this helps.

wspait · 2017-12-26T13:17:12Z

We are also having the same issue as @jianxuanbing. We are using version 4.5.0-preview1-25914-04. This code works fine locally (Windows 10), but not when run from a clean Server 2012 R2 or Server 2016 Windows image.

static void Main(string[] args)
 {
        try
        {
            Console.WriteLine("Calling System.Management code");
            ManagementObjectSearcher searcher = new ManagementObjectSearcher(@"root\CIMV2", "SELECT * FROM Win32_SystemEnclosure");
            Console.WriteLine("Application complete");
        }
        catch(Exception ex)
        {
            Console.WriteLine(ex);
        }     
}

This is the output:

Calling System.Management code
System.TypeInitializationException: The type initializer for 'System.Management.
WmiNetUtilsHelper' threw an exception. ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at System.Management.WmiNetUtilsHelper..cctor()
   --- End of inner exception stack trace ---
   at System.Management.MTAHelper.IsNoContextMTA()
   at System.Management.MTAHelper.CreateInMTA(Type type)
   at System.Management.ManagementPath.CreateWbemPath(String path)
   at System.Management.ManagementObjectSearcher..ctor(String scope, String queryString)
   at WmiNetUtilsHelperTest.Program.Main(String[] args)

danmoseley · 2017-12-27T04:06:00Z

@wspait the S.Management package requires a native binary that is included in the full.NET Framework 4.x. The error message could be clearer (please open a new issue). Meanwhile please add 4.x to your images.

STRATZ-Ken · 2017-12-27T13:34:54Z

@danmosemsft All of my machines have .Net 4.6.1 installed as that is what I use to run my program on. So it should have that dependency. I cant seem to make the error bigger either, myself.

danmoseley · 2017-12-27T20:15:04Z

Looks like if .NET 4.x is not found it would have bailed out cleanly. It gets further. It could be here:

                procAddr = Interop.Kernel32.GetProcAddress(loadLibrary, "Initialize");
                if( procAddr != IntPtr.Zero)
                {
                    Initialize_f  =(Initialize) Marshal.GetDelegateForFunctionPointer(procAddr, typeof(Initialize));
                }

        Initialize_f(CompatSwitches.AllowIManagementObjectQI);

The Initialize_f call is accidentally outside of the braces.

Although I would expect problems after this point anyway -- if the LL/GPA is failing.

danmoseley · 2017-12-27T23:42:18Z

I set up a Server 2012 R2 machine (which has 4.7:2117.0 which I think is 4.7.1) and your code works fine.

@STRATZ-Ken @wspait are either of you willing to debug? Symbols and sources should be available. The code to put a breakpoint on is the static constructor of WmiNetUtilsHelper.

danmoseley · 2017-12-27T23:45:04Z

To keep orgnaized I moved this to an issue https://github.com/dotnet/corefx/issues/26081 ... please continue discussion there not here

Paulo Janotti added 17 commits October 12, 2017 16:07

First pass building

5c4a004

Remove Instrumentation and WMIGenerator

6a3c28e

Resources to as used on CoreFX

feea27d

Opportunistic: some small changes related to warnings

Removed hard coded path to load wminet_utils

21101b3

Also moved so DllImport to use Common version of files.

Added ref, sln, and single basic test

d5f1883

Code builds and pass single test

Add CoreFX source header

19682f8

Removing unused using directives

05955f7

clean src proj references

b5d798f

A bit more test coverage (19%)

d890ffa

Sanitizer pass with default settings

56a1dfb

Adding WMIGenerator

044e488

This allows methods to generate CodeDom for strong type access to WMI objects.

Missing files from previous commit

63815fc

Some extra clean-up missed by SSS

f41d64d

Removing #ifdef dead code

c475b1a

Add pkg project

419d38e

Removing more dead code

16e0b4b

Removing dead code and small improvement to tests

f73ae4d

pjanotti requested review from danmoseley, AlexGhiondea, tarekgh and joperezr October 18, 2017 15:08

dnfclas added the cla-already-signed label Oct 18, 2017

Suppress CA1821 when generating PNSE assembly

97f5bdc

The finalizers are being generated empty for PNSE assembly. In such cases disable CA1821.

joperezr reviewed Oct 18, 2017

View reviewed changes

Paulo Janotti added 2 commits October 20, 2017 22:21

Skip tests on Windows Nano

04b2693

Missed files from previous commit

95ef161

pjanotti requested a review from weshaggard October 21, 2017 15:40

Paulo Janotti added 5 commits October 24, 2017 08:21

Untabify files and a bit more tests

dc9f3c4

Generate PNS Assembly for uap

703ace4

Add references needed by uap for PNS assembly

9578f50

PNS assembly message

4fbe944

Fixing package issue

0af2486

danmoseley reviewed Oct 25, 2017

View reviewed changes

pjanotti changed the title ~~WIP: Add System.Management~~ Add System.Management Oct 25, 2017

pjanotti merged commit 0f57714 into dotnet:master Oct 25, 2017

karelz added this to the 2.1.0 milestone Oct 28, 2017

pjanotti deleted the wmi branch October 30, 2017 16:59

safern mentioned this pull request Nov 2, 2017

Stabilize configurations for compat pack #25017

Merged

dotnet locked as resolved and limited conversation to collaborators Jan 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add System.Management #24719

Add System.Management #24719

pjanotti commented Oct 18, 2017 •

edited by karelz

Loading

tarekgh commented Oct 18, 2017 •

edited

Loading

pjanotti commented Oct 18, 2017

pjanotti commented Oct 18, 2017

tarekgh commented Oct 18, 2017

pjanotti commented Oct 18, 2017

joperezr Oct 18, 2017

pjanotti Oct 18, 2017

joperezr Oct 18, 2017

pjanotti Oct 18, 2017

joperezr Oct 18, 2017

pjanotti Oct 19, 2017

pjanotti commented Oct 21, 2017

4creators commented Oct 21, 2017

danmoseley Oct 25, 2017

safern Oct 25, 2017 •

edited

Loading

pjanotti Oct 25, 2017

safern Oct 25, 2017

safern Oct 25, 2017

pjanotti commented Oct 25, 2017

jianxuanbing commented Nov 16, 2017

pjanotti commented Nov 16, 2017

jianxuanbing commented Nov 17, 2017

jianxuanbing commented Nov 19, 2017

STRATZ-Ken commented Dec 22, 2017 •

edited

Loading

wspait commented Dec 26, 2017

danmoseley commented Dec 27, 2017

STRATZ-Ken commented Dec 27, 2017

danmoseley commented Dec 27, 2017

danmoseley commented Dec 27, 2017 •

edited

Loading

danmoseley commented Dec 27, 2017

Add System.Management #24719

Add System.Management #24719

Conversation

pjanotti commented Oct 18, 2017 • edited by karelz Loading

tarekgh commented Oct 18, 2017 • edited Loading

pjanotti commented Oct 18, 2017

pjanotti commented Oct 18, 2017

tarekgh commented Oct 18, 2017

pjanotti commented Oct 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjanotti commented Oct 21, 2017

4creators commented Oct 21, 2017

Choose a reason for hiding this comment

safern Oct 25, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjanotti commented Oct 25, 2017

jianxuanbing commented Nov 16, 2017

pjanotti commented Nov 16, 2017

jianxuanbing commented Nov 17, 2017

jianxuanbing commented Nov 19, 2017

STRATZ-Ken commented Dec 22, 2017 • edited Loading

wspait commented Dec 26, 2017

danmoseley commented Dec 27, 2017

STRATZ-Ken commented Dec 27, 2017

danmoseley commented Dec 27, 2017

danmoseley commented Dec 27, 2017 • edited Loading

danmoseley commented Dec 27, 2017

pjanotti commented Oct 18, 2017 •

edited by karelz

Loading

tarekgh commented Oct 18, 2017 •

edited

Loading

safern Oct 25, 2017 •

edited

Loading

STRATZ-Ken commented Dec 22, 2017 •

edited

Loading

danmoseley commented Dec 27, 2017 •

edited

Loading