Merge branch 'master' into RefOverloads

src/System.Numerics.Vectors/ref/System.Numerics.Vectors.csproj

@@ -5,6 +5,7 @@
     <ProjectGuid>{650277B5-9423-4ACE-BB54-2659995B21C7}</ProjectGuid>
     <DefineConstants Condition="'$(TargetGroup)' == 'netcoreapp'">$(DefineConstants);netcoreapp</DefineConstants>
     <DefineConstants Condition="'$(TargetGroup)' == 'uap'">$(DefineConstants);uap</DefineConstants>
+    <IsPartialFacadeAssembly Condition="'$(TargetGroup)' == 'netfx' OR '$(TargetGroup)' == 'net46'">true</IsPartialFacadeAssembly>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'net46-Debug|AnyCPU'" />
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'net46-Release|AnyCPU'" />

src/System.Numerics.Vectors/src/System/Numerics/Matrix4x4.cs

@@ -2753,9 +2753,9 @@ public static bool Decompose(Matrix4x4 matrix, out Vector3 scale, out Quaternion
                         uint cc;
                         float fAbsX, fAbsY, fAbsZ;
 
-                        fAbsX = MathF.Abs(pVectorBasis[a]->X);
-                        fAbsY = MathF.Abs(pVectorBasis[a]->Y);
-                        fAbsZ = MathF.Abs(pVectorBasis[a]->Z);
+                        fAbsX = (float)Math.Abs(pVectorBasis[a]->X);
+                        fAbsY = (float)Math.Abs(pVectorBasis[a]->Y);
+                        fAbsZ = (float)Math.Abs(pVectorBasis[a]->Z);
 
                         #region Ranking
                         if (fAbsX < fAbsY)
@@ -2954,9 +2954,9 @@ public static void Decompose(ref Matrix4x4 matrix, out bool succeeded, out Vecto
                         uint cc;
                         float fAbsX, fAbsY, fAbsZ;
 
-                        fAbsX = (float)Math.Abs(pVectorBasis[a]->X);
-                        fAbsY = (float)Math.Abs(pVectorBasis[a]->Y);
-                        fAbsZ = (float)Math.Abs(pVectorBasis[a]->Z);
+                        fAbsX = MathF.Abs(pVectorBasis[a]->X);
+                        fAbsY = MathF.Abs(pVectorBasis[a]->Y);
+                        fAbsZ = MathF.Abs(pVectorBasis[a]->Z);
 
                         #region Ranking
                         if (fAbsX < fAbsY)

src/System.Numerics.Vectors/tests/Vector2Tests.cs

@@ -587,10 +587,10 @@ public void Vector2TransformNormalTest()
             Vector2 actual;
 
             actual = Vector2.TransformNormal(v, m);
-            Assert.Equal(expected, actual);
+            Assert.True(MathHelper.Equal(expected, actual), "Vector2f.Tranform did not return the expected value.");
 
             Vector2.TransformNormal(ref v, ref m, out actual);
-            Assert.Equal(expected, actual);
+            Assert.True(MathHelper.Equal(expected, actual), "Vector2f.Tranform(ref, ref, out) did not return the expected value.");
         }
 
         // A test for TransformNormal (Vector2f, Matrix3x2)
@@ -606,10 +606,10 @@ public void Vector2TransformNormal3x2Test()
             Vector2 actual;
 
             actual = Vector2.TransformNormal(v, m);
-            Assert.Equal(expected, actual);
+            Assert.True(MathHelper.Equal(expected, actual), "Vector2f.Transform did not return the expected value.");
 
             Vector2.TransformNormal(ref v, ref m, out actual);
-            Assert.Equal(expected, actual);
+            Assert.True(MathHelper.Equal(expected, actual), "Vector2f.Transform(ref, ref, out) did not return the expected value.");
         }
 
         // A test for Transform (Vector2f, Quaternion)