Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Fast file enumeration for Windows #25426

Merged
merged 20 commits into from
Nov 30, 2017
Merged

Fast file enumeration for Windows #25426

merged 20 commits into from
Nov 30, 2017

Commits on Nov 29, 2017

  1. Fast file enumeration for Windows 

    Implements an optimized, low allocation replacement for file enumeration on Windows. In preliminary tests this improves performance at least two fold, particularly for recursive searches.

Removes agressive filter validation.

Copies and cleans up filename matching code from FileSystemWatcher.
    @JeremyKuhne
    JeremyKuhne committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    0fc66cd View commit details
    Browse the repository at this point in the history

  2. Fix comment and method name for Unix

    @JeremyKuhne
    JeremyKuhne committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    c4f14fa View commit details
    Browse the repository at this point in the history

  3. Change BOOLEAN accessibility to internal and add missing unix PathInt… 

    …ernal methods.
    @JeremyKuhne
    JeremyKuhne committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    c0622df View commit details
    Browse the repository at this point in the history

  4. Add issue for IsolatedStorage test on Unix

    @JeremyKuhne
    JeremyKuhne committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    9b8c50e View commit details
    Browse the repository at this point in the history

  5. Change FindEnumerable to be IEnumerator directly. 

    Address various feedback.

Still working on closure questions and using string.Create().
    @JeremyKuhne
    JeremyKuhne committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    c8c411e View commit details
    Browse the repository at this point in the history

  6. Fix closure allocations and address other feedback. 

    Still looking at string.Create().
    @JeremyKuhne
    JeremyKuhne committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    d711235 View commit details
    Browse the repository at this point in the history

  7. Use string.Create(), tweak enumerable disposal

    @JeremyKuhne
    JeremyKuhne committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    39ec45d View commit details
    Browse the repository at this point in the history

  8. Add extended prefix for UAP to fix test failure.

    @JeremyKuhne
    JeremyKuhne committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    a4a78d2 View commit details
    Browse the repository at this point in the history

  9. Push initial handle creation up front and ensure handle closure for e… 

    …rror states.
    @JeremyKuhne
    JeremyKuhne committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    20f882f View commit details
    Browse the repository at this point in the history

  10. Add missing CloseHandle file to Watcher and Ports projects.

    @JeremyKuhne
    JeremyKuhne committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    8099aad View commit details
    Browse the repository at this point in the history

  11. Fix disposal gate

    @JeremyKuhne
    JeremyKuhne committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    f0d6ec1 View commit details
    Browse the repository at this point in the history

  12. Change to use RtlNtStatusToDosError (which underlies Lsa method we we… 

    …re calling).
    @JeremyKuhne
    JeremyKuhne committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    7030750 View commit details
    Browse the repository at this point in the history

  13. Fix outerloop test.

    @JeremyKuhne
    JeremyKuhne committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    a61ca3e View commit details
    Browse the repository at this point in the history

  14. Tweak the comment and remove the ConditionalTheory as it isn't needed.

    @JeremyKuhne
    JeremyKuhne committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    b7783fb View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2017

  1. Align BOOLEAN with BOOL. Clean DosMatcher signature.

    @JeremyKuhne
    JeremyKuhne committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    2b5c49e View commit details
    Browse the repository at this point in the history

  2. Address feedback to make the enumerator threadsafe.

    @JeremyKuhne
    JeremyKuhne committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    9cbe9c4 View commit details
    Browse the repository at this point in the history

  3. Add JKotas regression test and lock dispose

    @JeremyKuhne
    JeremyKuhne committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    6da9522 View commit details
    Browse the repository at this point in the history

  4. Address various feedback. 

    Add length setter for ValueStringBuilder.
Remove Unix .. check for enumerable.
    @JeremyKuhne
    JeremyKuhne committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    1829bfb View commit details
    Browse the repository at this point in the history

  5. Tweak tests

    @JeremyKuhne
    JeremyKuhne committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    017394e View commit details
    Browse the repository at this point in the history

  6. Expand length for ValueStringBuilder with nulls like StringBuilder do… 

    …es. Add tests for it.
    @JeremyKuhne
    JeremyKuhne committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    77eeccf View commit details
    Browse the repository at this point in the history