This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Re-enable additional tests on WSL #25807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfree
added
area-System.IO
area-System.Net
os-windows-wsl
Priya91
reviewed
Dec 9, 2017
| @@ -365,7 +365,6 @@ public void WaitForConnectionOnAlreadyConnectedServer_Throws_InvalidOperationExc | |||
| } | |||
| } | |||
|
|
|||
| [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // https://github.com/Microsoft/BashOnWindows/issues/1011 | |||
| [PlatformSpecific(TestPlatforms.AnyUnix)] // Unix implemented on sockets, where disposal information doesn't propagate | |||
There was a problem hiding this comment.
This should be replaced with [Fact] attribute, otherwise these tests won't be discovered by xunit..
karelz
removed
area-System.Net
test bug
Priya91
reviewed
Dec 9, 2017
| @@ -60,6 +60,7 @@ public void PropertiesOfInvalidDrive() | |||
| Assert.Equal(invalidDriveName, invalidDrive.VolumeLabel); // VolumeLabel is equivalent to Name on Unix | |||
| } | |||
|
|
|||
| [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // https://github.com/dotnet/corefx/issues/11570 | |||
| [PlatformSpecific(TestPlatforms.AnyUnix)] | |||
There was a problem hiding this comment.
Is this intentional that you want to skip this test for subsystem?
There was a problem hiding this comment.
yes, this test is still failing.
|
@dotnet-bot test this please |
joshfree
added
the
* NO MERGE *
Disable some network tests on WindowsSubsystemForLinux due to https://github.com/dotnet/corefx/issues/15513
joshfree
removed
the
* NO MERGE *
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Re-enable DriveInfo test on Windows Subsystem for Linux https://github.com/dotnet/corefx/issues/11570 * Re-enable additional tests on WSL Related microsoft/WSL#1011 and microsoft/WSL#308 * correct xunit Facts * Disable some network tests on WSL Disable some network tests on WindowsSubsystemForLinux due to https://github.com/dotnet/corefx/issues/15513 Commit migrated from dotnet/corefx@1e95551
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related microsoft/WSL#1011 and microsoft/WSL#308