Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[WIP] Add Sort(...) extension methods for Span<T> #26859

Closed
wants to merge 32 commits into from
Closed

[WIP] Add Sort(...) extension methods for Span<T> #26859

wants to merge 32 commits into from

Commits on Dec 23, 2017

  1. add function signatures and minimal xml doc

    @nietras
    nietras committed Dec 23, 2017
    Configuration menu
    Copy the full SHA
    92702fe View commit details
    Browse the repository at this point in the history

  2. add helper stuff and scaffolding

    @nietras
    nietras committed Dec 23, 2017
    Configuration menu
    Copy the full SHA
    0c99da2 View commit details
    Browse the repository at this point in the history

  3. copy code from ArraySortHelper in coreclr

    @nietras
    nietras committed Dec 23, 2017
    Configuration menu
    Copy the full SHA
    48f655d View commit details
    Browse the repository at this point in the history

  4. more porting work

    @nietras
    nietras committed Dec 23, 2017
    Configuration menu
    Copy the full SHA
    57eb72f View commit details
    Browse the repository at this point in the history

  5. compiles

    @nietras
    nietras committed Dec 23, 2017
    Configuration menu
    Copy the full SHA
    2b8b08f View commit details
    Browse the repository at this point in the history

  6. comparablespansorthelper

    @nietras
    nietras committed Dec 23, 2017
    Configuration menu
    Copy the full SHA
    4272823 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2017

  1. fix make generic sorter

    @nietras
    nietras committed Dec 25, 2017
    Configuration menu
    Copy the full SHA
    25fc3c6 View commit details
    Browse the repository at this point in the history

  2. fix porting bug

    @nietras
    nietras committed Dec 25, 2017
    Configuration menu
    Copy the full SHA
    22d819b View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2017

  1. remove unnecessary swap checks, add reverse test

    @nietras
    nietras committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    ba1da6a View commit details
    Browse the repository at this point in the history

  2. fast middle via uint

    @nietras
    nietras committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    ec77c64 View commit details
    Browse the repository at this point in the history

  3. cleanup and a few comments

    @nietras
    nietras committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    4f500a3 View commit details
    Browse the repository at this point in the history

  4. optimize DownHeap

    @nietras
    nietras committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    4f2f822 View commit details
    Browse the repository at this point in the history

  5. add simple perf tests, with issues...

    @nietras
    nietras committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    758762b View commit details
    Browse the repository at this point in the history

  6. remove span sort perf for loop

    @nietras
    nietras committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    fcb63b5 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2017

  1. show type specialization can make perf as good or better as array sort.

    @nietras
    nietras committed Dec 30, 2017
    Configuration menu
    Copy the full SHA
    eff4ab4 View commit details
    Browse the repository at this point in the history

  2. make default sort helper static readonly

    @nietras
    nietras committed Dec 30, 2017
    Configuration menu
    Copy the full SHA
    0d99df1 View commit details
    Browse the repository at this point in the history

  3. expand perf tests

    @nietras
    nietras committed Dec 30, 2017
    Configuration menu
    Copy the full SHA
    03b1bef View commit details
    Browse the repository at this point in the history

  4. add new no sorting needed perf tests

    @nietras
    nietras committed Dec 30, 2017
    Configuration menu
    Copy the full SHA
    84691a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2018

  1. fix sort perf test

    @nietras
    nietras committed Jan 1, 2018
    Configuration menu
    Copy the full SHA
    c8dff35 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2018

  1. Add implementation code from bb5c9f89 in DotNetCross.Sorting "span-so… 

    …rt" branch.
    @nietras
    nietras committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    5352890 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2018

  1. Add KeysAndOrValues code from 4942ee74 in DotNetCross.Sorting "span-s… 

    …ort" branch.
    @nietras
    nietras committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    c109f6a View commit details
    Browse the repository at this point in the history

  2. Update to a71460be with Sort tests including possible overflow test.

    @nietras
    nietras committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    48be72d View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2018

  1. Update to fdbb7bcf from DotNetCross/Sorting

    @nietras
    nietras committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    7468485 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2018

  1. Add bogus comparer/comparable detection and exception throwing. Fix f… 

    …loat/double key values sorting when value not same type in the face of NaNs. Only when both key and value are same floating point is the direct path used, otherwise IComparable<> path is used. This resolves the differences for these tests.
    @nietras
    nietras committed Feb 11, 2018
    Configuration menu
    Copy the full SHA
    78aa18c View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2018

  1. Add TComparer, Comparison variants, remove bounds checks for TDirectC… 

    …omparer, all tests except one pass. (from DNX.Sorting 5b08fb1f).
    @nietras
    nietras committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    07b0105 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2018

  1. cleanup MemoryExtensions

    @nietras
    nietras committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    04c5c0b View commit details
    Browse the repository at this point in the history

  2. address ahsonkhan feedback, before sort test split up

    @nietras
    nietras committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    ced09bd View commit details
    Browse the repository at this point in the history

  3. Split Sort test code into three files.

    @nietras
    nietras committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    4259560 View commit details
    Browse the repository at this point in the history

  4. Remove uncommented Sort3 code

    @nietras
    nietras committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    9527a49 View commit details
    Browse the repository at this point in the history

  5. Add below lines to comments

    @nietras
    nietras committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    146029f View commit details
    Browse the repository at this point in the history

  6. Remove AggressiveInlining attributes

    @nietras
    nietras committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    e44b8b6 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2018

  1. Add license to Common

    @nietras
    nietras committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    596df18 View commit details
    Browse the repository at this point in the history