Fix some compression tests

[ianhays]

• Remove an unnecessary, flaky compression test
• Reduce brotli performance test time down to ~13 minutes. The problem looks to be that since i was using custom inneriterations the perf runner was going to the max time clock length each time, regardless of max iteration count. I switched my tests to use the Benchmark InnerIterations field and also artificially limited the max Compression iteration count to 100 instead of the usual 1000.

resolves https://github.com/dotnet/corefx/issues/26089
resolves https://github.com/dotnet/corefx/issues/26566

[ianhays]

@dotnet-bot help

[dotnet-bot]

Welcome to the dotnet/corefx Repository

The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR

The following commands are valid for all PRs and repositories.

Click to expand

Comment Phrase	Action
@dotnet-bot test this please	Re-run all legs. Use sparingly
@dotnet-bot test ci please	Generates (but does not run) jobs based on changes to the groovy job definitions in this branch
@dotnet-bot help	Print this help message

The following jobs are launched by default for each PR against dotnet/corefx:master.

Click to expand

Comment Phrase	Job Launched
@dotnet-bot test Linux arm Release Build	Linux arm Release Build
@dotnet-bot test Tizen armel Debug Build	Tizen armel Debug Build

The following optional jobs are available in PRs against dotnet/corefx:master.

Click to expand

Comment Phrase	Job Launched
@dotnet-bot test innerloop CentOS7.1 Debug	Queues Innerloop CentOS7.1 Debug x64 Build and Test
@dotnet-bot test innerloop CentOS7.1 Release	Queues Innerloop CentOS7.1 Release x64 Build and Test
@dotnet-bot test code coverage	Queues Code Coverage Windows Debug
@dotnet-bot test innerloop Debian8.4 Debug	Queues Innerloop Debian8.4 Debug x64 Build and Test
@dotnet-bot test innerloop Debian8.4 Release	Queues Innerloop Debian8.4 Release x64 Build and Test
@dotnet-bot test innerloop Fedora24 Debug	Queues Innerloop Fedora24 Debug x64 Build and Test
@dotnet-bot test innerloop Fedora24 Release	Queues Innerloop Fedora24 Release x64 Build and Test
@dotnet-bot test Linux arm Debug	Queues Linux arm Debug Build
@dotnet-bot test code formatter check	Queues Code Formatter Check
@dotnet-bot test innerloop OSX10.12 Debug	Queues Innerloop OSX10.12 Debug x64 Build and Test
@dotnet-bot test innerloop OSX10.12 Release	Queues Innerloop OSX10.12 Release x64 Build and Test
@dotnet-bot test outerloop netcoreapp CentOS7.1 Debug	Queues OuterLoop netcoreapp CentOS7.1 Debug x64
@dotnet-bot test outerloop netcoreapp CentOS7.1 Release	Queues OuterLoop netcoreapp CentOS7.1 Release x64
@dotnet-bot test outerloop netcoreapp Debian8.4 Debug	Queues OuterLoop netcoreapp Debian8.4 Debug x64
@dotnet-bot test outerloop netcoreapp Debian8.4 Release	Queues OuterLoop netcoreapp Debian8.4 Release x64
@dotnet-bot test outerloop netcoreapp Fedora24 Debug	Queues OuterLoop netcoreapp Fedora24 Debug x64
@dotnet-bot test outerloop netcoreapp Fedora24 Release	Queues OuterLoop netcoreapp Fedora24 Release x64
@dotnet-bot test outerloop netcoreapp OSX10.12 Debug	Queues OuterLoop netcoreapp OSX10.12 Debug x64
@dotnet-bot test outerloop netcoreapp OSX10.12 Release	Queues OuterLoop netcoreapp OSX10.12 Release x64
@dotnet-bot test outerloop netcoreapp PortableLinux Debug	Queues OuterLoop netcoreapp PortableLinux Debug x64
@dotnet-bot test outerloop netcoreapp PortableLinux Release	Queues OuterLoop netcoreapp PortableLinux Release x64
@dotnet-bot test outerloop netcoreapp RHEL7.2 Debug	Queues OuterLoop netcoreapp RHEL7.2 Debug x64
@dotnet-bot test outerloop netcoreapp RHEL7.2 Release	Queues OuterLoop netcoreapp RHEL7.2 Release x64
@dotnet-bot test outerloop netcoreapp Ubuntu14.04 Debug	Queues OuterLoop netcoreapp Ubuntu14.04 Debug x64
@dotnet-bot test outerloop netcoreapp Ubuntu14.04 Release	Queues OuterLoop netcoreapp Ubuntu14.04 Release x64
@dotnet-bot test outerloop netcoreapp Ubuntu16.04 Debug	Queues OuterLoop netcoreapp Ubuntu16.04 Debug x64
@dotnet-bot test outerloop netcoreapp Ubuntu16.04 Release	Queues OuterLoop netcoreapp Ubuntu16.04 Release x64
@dotnet-bot test outerloop netcoreapp Ubuntu16.10 Debug	Queues OuterLoop netcoreapp Ubuntu16.10 Debug x64
@dotnet-bot test outerloop netcoreapp Ubuntu16.10 Release	Queues OuterLoop netcoreapp Ubuntu16.10 Release x64
@dotnet-bot test outerloop netcoreapp Windows 7 Debug	Queues OuterLoop netcoreapp Windows 7 Debug x64
@dotnet-bot test outerloop netcoreapp Windows 7 Release	Queues OuterLoop netcoreapp Windows 7 Release x64
@dotnet-bot test outerloop netcoreapp Windows_NT Debug	Queues OuterLoop netcoreapp Windows_NT Debug x64
@dotnet-bot test outerloop netcoreapp Windows_NT Release	Queues OuterLoop netcoreapp Windows_NT Release x64
@dotnet-bot test innerloop PortableLinux Debug	Queues Innerloop PortableLinux Debug x64 Build and Test
@dotnet-bot test innerloop PortableLinux Release	Queues Innerloop PortableLinux Release x64 Build and Test
@dotnet-bot test innerloop RHEL7.2 Debug	Queues Innerloop RHEL7.2 Debug x64 Build and Test
@dotnet-bot test innerloop RHEL7.2 Release	Queues Innerloop RHEL7.2 Release x64 Build and Test
@dotnet-bot test Tizen armel Release	Queues Tizen armel Release Build
@dotnet-bot test innerloop Ubuntu14.04 Debug	Queues Innerloop Ubuntu14.04 Debug x64 Build and Test
@dotnet-bot test innerloop Ubuntu14.04 Release	Queues Innerloop Ubuntu14.04 Release x64 Build and Test
@dotnet-bot test innerloop Ubuntu16.04 Debug	Queues Innerloop Ubuntu16.04 Debug x64 Build and Test
@dotnet-bot test innerloop Ubuntu16.04 Release	Queues Innerloop Ubuntu16.04 Release x64 Build and Test
@dotnet-bot test innerloop Ubuntu16.10 Debug	Queues Innerloop Ubuntu16.10 Debug x64 Build and Test
@dotnet-bot test innerloop Ubuntu16.10 Release	Queues Innerloop Ubuntu16.10 Release x64 Build and Test
@dotnet-bot test innerloop Windows_NT Debug	Queues Innerloop Windows_NT Debug x86 Build and Test
@dotnet-bot test innerloop Windows_NT Release	Queues Innerloop Windows_NT Release x64 Build and Test

Have a nice day!

[ianhays]

Hmm, looks like dotnet-bot doesn't want to help me with performance run triggers.

[ianhays]

@dotnet-bot test Windows_NT perf

[dotnet-bot]

Welcome to the dotnet/corefx Repository

The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR

The following commands are valid for all PRs and repositories.

Click to expand

Comment Phrase	Action
@dotnet-bot test this please	Re-run all legs. Use sparingly
@dotnet-bot test ci please	Generates (but does not run) jobs based on changes to the groovy job definitions in this branch
@dotnet-bot help	Print this help message

The following jobs are launched by default for each PR against dotnet/corefx:master.

Click to expand

Comment Phrase	Job Launched
@dotnet-bot test Alpine.3.6 x64 Debug Build	Alpine.3.6 x64 Debug Build
@dotnet-bot test Linux x64 Release Build	Linux x64 Release Build
@dotnet-bot test OSX x64 Debug Build	OSX x64 Debug Build
@dotnet-bot test Packaging All Configurations x64 Debug Build	Packaging All Configurations x64 Debug Build
@dotnet-bot test Windows x64 Debug Build	Windows x64 Debug Build
@dotnet-bot test Windows x86 Release Build	Windows x86 Release Build
@dotnet-bot test NETFX x86 Release Build	NETFX x86 Release Build

The following optional jobs are available in PRs against dotnet/corefx:master.

Click to expand

Comment Phrase	Job Launched
@dotnet-bot test Outerloop Alpine.3.6 x64 Debug Build	Queues Outerloop Alpine.3.6 x64 Debug Build
@dotnet-bot test Alpine.3.6 x64 Release Build	Queues Alpine.3.6 x64 Release Build
@dotnet-bot test Outerloop Alpine.3.6 x64 Release Build	Queues Outerloop Alpine.3.6 x64 Release Build
@dotnet-bot test CentOS.6 x64 Debug Build	Queues CentOS.6 x64 Debug Build
@dotnet-bot test Outerloop CentOS.6 x64 Debug Build	Queues Outerloop CentOS.6 x64 Debug Build
@dotnet-bot test CentOS.6 x64 Release Build	Queues CentOS.6 x64 Release Build
@dotnet-bot test Outerloop CentOS.6 x64 Release Build	Queues Outerloop CentOS.6 x64 Release Build
@dotnet-bot test Linux x64 Debug Build	Queues Linux x64 Debug Build
@dotnet-bot test Outerloop Linux x64 Debug Build	Queues Outerloop Linux x64 Debug Build
@dotnet-bot test Outerloop Linux x64 Release Build	Queues Outerloop Linux x64 Release Build
@dotnet-bot test Outerloop OSX x64 Debug Build	Queues Outerloop OSX x64 Debug Build
@dotnet-bot test OSX x64 Release Build	Queues OSX x64 Release Build
@dotnet-bot test Outerloop OSX x64 Release Build	Queues Outerloop OSX x64 Release Build
@dotnet-bot test Outerloop Packaging All Configurations x64 Debug Build	Queues Outerloop Packaging All Configurations x64 Debug Build
@dotnet-bot test Packaging All Configurations x86 Debug Build	Queues Packaging All Configurations x86 Debug Build
@dotnet-bot test Outerloop Packaging All Configurations x86 Debug Build	Queues Outerloop Packaging All Configurations x86 Debug Build
@dotnet-bot test Packaging All Configurations x64 Release Build	Queues Packaging All Configurations x64 Release Build
@dotnet-bot test Outerloop Packaging All Configurations x64 Release Build	Queues Outerloop Packaging All Configurations x64 Release Build
@dotnet-bot test Packaging All Configurations x86 Release Build	Queues Packaging All Configurations x86 Release Build
@dotnet-bot test Outerloop Packaging All Configurations x86 Release Build	Queues Outerloop Packaging All Configurations x86 Release Build
@dotnet-bot test Outerloop Windows x64 Debug Build	Queues Outerloop Windows x64 Debug Build
@dotnet-bot test Windows x86 Debug Build	Queues Windows x86 Debug Build
@dotnet-bot test Outerloop Windows x86 Debug Build	Queues Outerloop Windows x86 Debug Build
@dotnet-bot test Windows x64 Release Build	Queues Windows x64 Release Build
@dotnet-bot test Outerloop Windows x64 Release Build	Queues Outerloop Windows x64 Release Build
@dotnet-bot test Outerloop Windows x86 Release Build	Queues Outerloop Windows x86 Release Build
@dotnet-bot test NETFX x64 Debug Build	Queues NETFX x64 Debug Build
@dotnet-bot test Outerloop NETFX x64 Debug Build	Queues Outerloop NETFX x64 Debug Build
@dotnet-bot test NETFX x86 Debug Build	Queues NETFX x86 Debug Build
@dotnet-bot test Outerloop NETFX x86 Debug Build	Queues Outerloop NETFX x86 Debug Build
@dotnet-bot test NETFX x64 Release Build	Queues NETFX x64 Release Build
@dotnet-bot test Outerloop NETFX x64 Release Build	Queues Outerloop NETFX x64 Release Build
@dotnet-bot test Outerloop NETFX x86 Release Build	Queues Outerloop NETFX x86 Release Build

Have a nice day!

[stephentoub]

Remove an unnecessary, flaky compression test

Do we understand the source if the flakiness?

[ianhays]

Do we understand the source if the flakiness?

Yeah, I tried to write a test that would work for a general compression stream when you dispose with an unfinished WriteAsync, but the behaviors in BrotliStream and DeflateStream are different enough that my test works for BrotliStream but has a race condition in DeflateStream due to the WriteOutput/SetInput/WriteOutput structure whereas BrotliStream is just SetInput&WriteOutput in one step.

[ianhays]

Brotli performance tests now run on the jenkins machine in 7 minutes.