This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Skip portable PDB conversion #27340
Merged
Skip portable PDB conversion #27340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few bugs that cause the conversion to fail in some cases and given we plan to use a different model moving forward this is just temporarily disabling the conversion to unblock the builds.
|
LGTM. |
Member
Author
|
@mikem8361 is there already a tracking issue for the work to change this in the long run? |
|
I think there is a tracking issue. @dagood? I think he created one. |
Member
|
I poked around a bit and wasn't able to find one. I was tracking some symbol publish stuff for prodcon, but that's separate infrastructure. I'll file issues in CoreCLR and CoreFX to switch to the symbol upload package in |
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Oct 22, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
that referenced
this pull request
Oct 22, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…bConversion Skip portable PDB conversion Commit migrated from dotnet/corefx@060b69e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few bugs that cause the conversion to fail in some cases
and given we plan to use a different model moving forward this is
just temporarily disabling the conversion to unblock the builds.
cc @mikem8361 @dagood