This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Update regular expressions collections to implement IReadOnlyList<T> #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(fixes #271) * CaptureCollection implements IReadOnlyList<Capture> * GroupCollection implements IReadOnlyList<Group> * MatchCollection implements IReadOnlyList<Match>
davkean
added
area-System.Text.RegularExpressions
api-needs-work
|
Just want to set clear expectations here - we're not planning on taking any APIs additions until the middle of January; we're waiting to finalize our branching structure, and the API review process (a draft of which should be published before Christmas). |
|
Thanks for the heads-up. I'm looking forward to watching and learning more about the processes here regardless of the final outcome. 😄 |
|
@terrajobst has just posted our API Review process proposal, feel free to comment over here: https://github.com/dotnet/corefx/issues/294. |
|
Closing this per my notes in #271. |
7 tasks
Olafski
pushed a commit
to Olafski/corefx
that referenced
this pull request
Jun 15, 2017
* Add Dockerfile - Added Dockerfile for app - Made the app a bit shorter - Improved app with string interpolation usage * Add trailing CR * Simplify string joining
akoeplinger
pushed a commit
to akoeplinger/corefx
that referenced
this pull request
May 27, 2019
[master] Use fallbacks when link() fails
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271
I believe this is the least intrusive path to implementing the requested functionality.
I considered the following items but decided to not include them with this pull request.
GroupEnumeratoris internal, so it might be possible to change the type ofGroupEnumerator.CapturefromCapturetoGroup. This would make the explicit cast in the genericCurrentproperty unnecessary.CaptureCollectionto implementIReadOnlyDictionary<string, Capture>, primarily because it's a larger change with the addition of theKeysandValuesproperties (even if they are explicitly implemented). This should probably be reviewed independently from a straightforward implementation ofIReadOnlyList<T>.