Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Collapse AsSpan().Slice(...) into .AsSpan(...) #27867

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Mar 8, 2018

Fixes #27330

@tarekgh
Copy link
Member Author

tarekgh commented Mar 8, 2018

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of unrelated whitespace changes in the PR. Other than that, LGTM.

@tarekgh
Copy link
Member Author

tarekgh commented Mar 8, 2018

There's a lot of unrelated whitespace changes in the PR

Yes, I prefer setting my editor to remove the white spaces at the end of the lines. by the way, if you use code flow would be easier to see the actual changes and ignoring the space differences.

thanks for your review.

@stephentoub
Copy link
Member

stephentoub commented Mar 8, 2018

by the way, if you use code flow would be easier to see the actual changes and ignoring the space differences.

Or just adding ?w=1 to the url in the browser, which is what I did.

@stephentoub
Copy link
Member

stephentoub commented Mar 8, 2018

Yes, I prefer setting my editor to remove the white spaces at the end of the lines.

Ok. It'd be nice in the future if such widespread changes were isolated to their own commit or PR. Just helps with understanding why changes are being made, as well as when reviewing.

@tarekgh tarekgh merged commit 8ad2b10 into dotnet:master Mar 8, 2018
dotnet-bot pushed a commit to dotnet/coreclr that referenced this pull request Mar 8, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
tarekgh added a commit to dotnet/coreclr that referenced this pull request Mar 9, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
tarekgh added a commit to dotnet/coreclr that referenced this pull request Mar 9, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot pushed a commit to dotnet/corert that referenced this pull request Mar 9, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
tarekgh added a commit to dotnet/corert that referenced this pull request Mar 9, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
@karelz karelz added this to the 2.1.0 milestone Mar 10, 2018
kbaladurin pushed a commit to kbaladurin/corert that referenced this pull request Mar 15, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
@tarekgh tarekgh deleted the CleanSpanSlice branch April 19, 2018 20:18
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants