-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Collapse AsSpan().Slice(...) into .AsSpan(...) #27867
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of unrelated whitespace changes in the PR. Other than that, LGTM.
Yes, I prefer setting my editor to remove the white spaces at the end of the lines. by the way, if you use code flow would be easier to see the actual changes and ignoring the space differences. thanks for your review. |
Or just adding |
Ok. It'd be nice in the future if such widespread changes were isolated to their own commit or PR. Just helps with understanding why changes are being made, as well as when reviewing. |
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Fixes #27330