This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Change csharp_indent_labels from flush_left to one_less_than_current #28121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfree
approved these changes
Mar 16, 2018
|
@dotnet-bot test OSX x64 Debug Build |
lkts
approved these changes
Mar 16, 2018
|
@ahsonkhan, can we update the coding style guidelines to call this out as well? Otherwise, LGTM |
ericstj
pushed a commit
to ericstj/corefx
that referenced
this pull request
Mar 28, 2018
…otnet#28121) * Change csharp_indent_labels from flush_left to one_less_than_current * Update coding-style guidelines to include label formatting.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…otnet/corefx#28121) * Change csharp_indent_labels from flush_left to one_less_than_current * Update coding-style guidelines to include label formatting. Commit migrated from dotnet/corefx@5f5ff6d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the places where we use goto and labels (that I have come across) use one_less_than_current formatting pattern.
I will make the same change in coreclr as well - dotnet/coreclr#16983
cc @jkotas, @danmosemsft, @cod7alex, @karelz, @tannergooding