This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix build with xcode 9.3 on OSX #28768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The c_static_assert definition is causing build problems on OSX. The compiler complains about the typedef we use to implement the c_static_assert: declaration shadows a typedef in the global scope [-Werror,-Wshadow] This is due to multiple static asserts To fix it, I have modified the c_static_assert to use _Static_assert C feature that's available in clang.
stephentoub
approved these changes
Apr 3, 2018
|
nit, the issue it fixes is https://github.com/dotnet/corefx/issues/28756 |
bartonjs
approved these changes
Apr 3, 2018
|
@kasper3 thanks for spotting the wrong issue reference. |
|
Merging, the OSX failure is a known issue in the managed tests run. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
The c_static_assert definition is causing build problems on OSX. The compiler complains about the typedef we use to implement the c_static_assert: declaration shadows a typedef in the global scope [-Werror,-Wshadow] This is due to multiple static asserts To fix it, I have modified the c_static_assert to use _Static_assert C feature that's available in clang. Commit migrated from dotnet/corefx@133d190
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The c_static_assert definition is causing build problems on OSX.
The compiler complains about the typedef we use to implement the
c_static_assert:
declaration shadows a typedef in the global scope [-Werror,-Wshadow]This is due to multiple static asserts
To fix it, I have modified the c_static_assert to use _Static_assert
C feature that's available in clang.