Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Making Spanish CI leg as the defaut target CI #29004

Merged
merged 2 commits into from
Apr 19, 2018
Merged

Making Spanish CI leg as the defaut target CI #29004

merged 2 commits into from
Apr 19, 2018

Conversation

Anipik
Copy link

@Anipik Anipik commented Apr 10, 2018

Merge After #28952 and #29009

@Anipik Anipik requested review from MattGal and safern April 10, 2018 23:04
@Anipik
Copy link
Author

Anipik commented Apr 11, 2018

@dotnet-bot test Windows x64 Debug Build
@dotnet-bot test Windows x86 Release Build

@@ -74,13 +74,11 @@ simpleNode('Windows_NT','latest') {
{
targetHelixQueues = ['Windows.10.Amd64.Open',
'Windows.7.Amd64.Open',
'Windows.81.Amd64.Open',]
'Windows.81.Amd64.Open',
'Windows.10.Amd64.ClientRS3.ES.Open',]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to get rid of the default Windows.10.Amd64.Open? It should be the same as the Windows.10 in spanish.

cc: @danmosemsft

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danmosemsft why its a good idea to get rid of English Language Build ?

@stephentoub stephentoub modified the milestones: Future, 2.2.0 Apr 11, 2018
@danmoseley
Copy link
Member

I suggest holding this until 2.2

@Anipik
Copy link
Author

Anipik commented Apr 17, 2018

@dotnet-bot test Windows x64 Debug Build
@dotnet-bot test Windows x86 Release Build

@Anipik
Copy link
Author

Anipik commented Apr 18, 2018

@dotnet-bot test OSX x64 Debug Build

@danmoseley
Copy link
Member

Odd.

OSX.1013.Amd64.Open-x64-Debug
Get Repro environment
Unhandled Exception of Type Xunit.Sdk.TrueException
Message :
Timed out after 60000ms waiting for remote process 61432
Expected: True
Actual:   False
Stack Trace :
   at System.Diagnostics.RemoteExecutorTestBase.RemoteInvokeHandle.Dispose(Boolean disposing) in /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/CoreFx.Private.TestUtilities/src/System/Diagnostics/RemoteExecutorTestBase.cs:line 241
   at System.Diagnostics.RemoteExecutorTestBase.RemoteInvokeHandle.Dispose() in /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/CoreFx.Private.TestUtilities/src/System/Diagnostics/RemoteExecutorTestBase.cs:line 228
   at System.Tests.EnvironmentTests.CurrentDirectory_SetToValidOtherDirectory() in /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Runtime.Extensions/tests/System/EnvironmentTests.cs:line 41

@danmoseley
Copy link
Member

@Anipik if you like, but it's not actionable except for potentially looping the test locally on your macbook. You can ignore the test for this change.

@Anipik
Copy link
Author

Anipik commented Apr 18, 2018

@danmosemsft can you approve these changes ?

@Anipik
Copy link
Author

Anipik commented Apr 19, 2018

@dotnet-bot test OSX x64 Debug Build

@Anipik Anipik merged commit 5dd1f5e into dotnet:master Apr 19, 2018
@Anipik Anipik deleted the ReEnableSpanishCI branch April 19, 2018 17:08
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants