-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Making Spanish CI leg as the defaut target CI #29004
Conversation
@dotnet-bot test Windows x64 Debug Build |
buildpipeline/windows.groovy
Outdated
@@ -74,13 +74,11 @@ simpleNode('Windows_NT','latest') { | |||
{ | |||
targetHelixQueues = ['Windows.10.Amd64.Open', | |||
'Windows.7.Amd64.Open', | |||
'Windows.81.Amd64.Open',] | |||
'Windows.81.Amd64.Open', | |||
'Windows.10.Amd64.ClientRS3.ES.Open',] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to get rid of the default Windows.10.Amd64.Open? It should be the same as the Windows.10 in spanish.
cc: @danmosemsft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danmosemsft why its a good idea to get rid of English Language Build ?
I suggest holding this until 2.2 |
@dotnet-bot test Windows x64 Debug Build |
@dotnet-bot test OSX x64 Debug Build |
Odd.
|
https://mc.dot.net/#/user/Anipik/pr~2Fjenkins~2Fdotnet~2Fcorefx~2Fmaster~2F/test~2Ffunctional~2Fcli~2F/0a9a4e458433f42dcbdd1fc46274330f7913e8d5/workItem/System.Runtime.Extensions.Tests/analysis/xunit/System.Tests.EnvironmentTests~2FCurrentDirectory_SetToValidOtherDirectory |
@Anipik if you like, but it's not actionable except for potentially looping the test locally on your macbook. You can ignore the test for this change. |
@danmosemsft can you approve these changes ? |
@dotnet-bot test OSX x64 Debug Build |
Merge After #28952 and #29009