Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Revert "Fix Uri.Host for IPv6 Link-local address (#29829)" #30062

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

caesar-chen
Copy link
Contributor

@caesar-chen caesar-chen commented Jun 1, 2018

This reverts commit f7a8cf1, which regressed ASP.NET. (https://github.com/dotnet/corefx/issues/28863#issuecomment-393993963)

We need to reconsider how to solve #28863

@caesar-chen caesar-chen added this to the 3.0 milestone Jun 1, 2018
@caesar-chen caesar-chen self-assigned this Jun 1, 2018
@caesar-chen caesar-chen requested a review from davidsh June 1, 2018 21:00
@caesar-chen
Copy link
Contributor Author

@dotnet-bot test Outerloop Windows x64 Debug Build
@dotnet-bot test Outerloop Linux x64 Debug Build
@dotnet-bot test Outerloop NETFX x86 Debug Build
@dotnet-bot test Outerloop UWP CoreCLR x64 Debug Build
@dotnet-bot test Outerloop Linux x64 Release Build please
@dotnet-bot test Outerloop Windows x86 Release Build please

@davidsh davidsh requested review from stephentoub and a team June 1, 2018 21:15
@davidsh
Copy link
Contributor

davidsh commented Jun 1, 2018

cc: @MarcoRossignoli

@davidsh
Copy link
Contributor

davidsh commented Jun 1, 2018

cc: @Tratcher

@Tratcher
Copy link
Member

Tratcher commented Jun 1, 2018

FYI this has been mitigated in Asp.Net's tests: dotnet/extensions#369. We're not dependent on any changes at your layer, but make sure you get SocketsHttpHandler Host header sorted out eventually.

@davidsh
Copy link
Contributor

davidsh commented Jun 4, 2018

FYI this has been mitigated in Asp.Net's tests: dotnet/extensions#369. We're not dependent on any changes at your layer, but make sure you get SocketsHttpHandler Host header sorted out eventually.

@Tratcher
I noticed in dotnet/extensions#369 that you're using the .Authority property. Is that DNS-safe? Why aren't you using .IdnHost which makes sure that the hostname is ASCII characters only and will use Punnycode if there are Unicode characters (which can't be used in HTTP headers such as Host: header)?

Although, it's ironic because Uri.IdnHost has the scope-id in it for IPv6 LinkLocal addresses but doesn't have the square brackets around the IPv6 address.

@Tratcher
Copy link
Member

Tratcher commented Jun 4, 2018

That's only a test client and apparently it's not used for any IDN tests.

@caesar-chen caesar-chen merged commit e5bb0b5 into dotnet:master Jun 4, 2018
@caesar-chen caesar-chen deleted the revert_lla branch June 4, 2018 21:41
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants