Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

support for correct Tools on Linux/ARM #31160

Merged
merged 1 commit into from
Jul 19, 2018
Merged

support for correct Tools on Linux/ARM #31160

merged 1 commit into from
Jul 19, 2018

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Jul 18, 2018

I did not find any command line override. This change allows to get correct tools on arm system.
This is beginning of changes to support build on arm and match coreclr.

Build speed may vary depending on the system. But it is nice to build and run tests quickly in same workflow as x86.

@wfurt wfurt added os-linux Linux OS (any supported distro) arch-arm32 labels Jul 18, 2018
@wfurt wfurt self-assigned this Jul 18, 2018
@wfurt wfurt requested review from eerhardt and weshaggard July 18, 2018 18:23
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Are you planning to make the same change in coreclr and core-setup?

@wfurt
Copy link
Member Author

wfurt commented Jul 18, 2018

coreclr should already build according to @janvorli (I did not tested)
My next step is to keep fixing corefx. There is problem with Microsoft.Cci as it does unaligned access and fails on arm.

@weshaggard
Copy link
Member

I don't see support for those architectures in coreclr's init-tools.sh https://github.com/dotnet/coreclr/blob/master/init-tools.sh.

@wfurt
Copy link
Member Author

wfurt commented Jul 18, 2018

ok. I'll give it try. Maybe he did not build managed part.

@wfurt wfurt merged commit a53adfc into dotnet:master Jul 19, 2018
@karelz karelz added this to the 3.0 milestone Jul 19, 2018
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt wfurt deleted the arm branch June 15, 2020 18:21
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm32 os-linux Linux OS (any supported distro)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants