This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Filter binplace and harvest package depproj's to only direct reference #31167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
reviewed
Jul 18, 2018
| @@ -9,6 +9,11 @@ | |||
|
|
|||
| <Import Project="harvestPackages.props" /> | |||
|
|
|||
| <ItemGroup> | |||
| <!-- Only include the assets from the direct packages we reference in the output --> | |||
| <PackageToInclude Include="@(PackageReference)" /> | |||
There was a problem hiding this comment.
We don't binplace in harvestPackages.depproj, is this just in case?
There was a problem hiding this comment.
Good point I forgot we don't copy. I will remove this.
ViktorHofer
approved these changes
Jul 18, 2018
weshaggard
force-pushed
the
FixRaceConditionInExternalRestore
branch
from
b3b549b to
f24fb67
Compare
We don't need to copy out the full closure of all packages for this project so only copy the packages that are directly referenced.
weshaggard
force-pushed
the
FixRaceConditionInExternalRestore
branch
from
f24fb67 to
f58f59b
Compare
|
test Packaging All Configurations x64 Debug Build Got a weird error that seems unrelated: |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…efx#31167) Don't copy out the full closure of all packages for binplacePackages. Commit migrated from dotnet/corefx@eb41cd4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to copy out the full closure of all packages for
these project so only copy the packages that are directly referenced.
cc @ViktorHofer @ericstj
Fixes https://github.com/dotnet/corefx/issues/31156