Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Expose MethodImplOptions.AggressiveOptimization and MethodImplAttributes.AggressiveOptimization #32322

Merged
merged 3 commits into from
Oct 25, 2018

Conversation

@kouvel kouvel added * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) area-System.Runtime.CompilerServices labels Sep 17, 2018
@kouvel kouvel added this to the 3.0 milestone Sep 17, 2018
@kouvel kouvel self-assigned this Sep 17, 2018
@kouvel kouvel requested a review from noahfalk September 18, 2018 16:48
@kouvel kouvel removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 3, 2018
@kouvel
Copy link
Member Author

kouvel commented Oct 4, 2018

@dotnet-bot test this please

@kouvel
Copy link
Member Author

kouvel commented Oct 4, 2018

Forgot to add the new test file, added in latest commit

@kouvel
Copy link
Member Author

kouvel commented Oct 5, 2018

Missed MethodImplAttributes, which has values from MethodImplOptions as well. Updated description inline above, fixed test, and opened new API review.

@kouvel kouvel changed the title Expose MethodImplOptions.AggressiveOptimization Expose MethodImplOptions.AggressiveOptimization and MethodImplAttributes.AggressiveOptimization Oct 5, 2018
@kouvel
Copy link
Member Author

kouvel commented Oct 22, 2018

@dotnet-bot test this please

@kouvel
Copy link
Member Author

kouvel commented Oct 23, 2018

@dotnet-bot test this please

2 similar comments
@kouvel
Copy link
Member Author

kouvel commented Oct 23, 2018

@dotnet-bot test this please

@kouvel
Copy link
Member Author

kouvel commented Oct 24, 2018

@dotnet-bot test this please

@stephentoub stephentoub merged commit 3f0a1ee into dotnet:master Oct 25, 2018
@kouvel kouvel deleted the NoTierMethodFx branch October 25, 2018 09:31
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…tes.AggressiveOptimization (dotnet/corefx#32322)

* Expose MethodImplOptions.AggressiveOptimization

Part of fix for https://github.com/dotnet/corefx/issues/32235
Depends on dotnet/coreclr#20009
API review: https://github.com/dotnet/corefx/issues/32235

* Include new test

* Expose MethodImplAttributes.AggressiveOptimization and fix test

API review: https://github.com/dotnet/corefx/issues/32628


Commit migrated from dotnet/corefx@3f0a1ee
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants