This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add IAsyncDisposable implementations to refs #34898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently when I added the DisposeAsync methods to the refs, I didn't actually mark the corresponding types as implementing the interface. This fixes that.
|
Don't we have tools that find ref/def mismatches? |
We do, but the methods are there in both. I don't believe it looks at interfaces themselves. @ericstj? |
|
We do ref -> src comparison for anything with a reference. We don't do the src -> ref comparison (AKA: reverse) for things with runtime references: https://github.com/dotnet/arcade/blob/cccfb5be4409acef7e07981d2b4fceeb1d9a992f/src/Microsoft.DotNet.ApiCompat/build/Microsoft.DotNet.ApiCompat.targets#L89-L90 The reasoning given in the initial commit was
|
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Apparently when I added the DisposeAsync methods to the refs, I didn't actually mark the corresponding types as implementing the interface. This fixes that. Commit migrated from dotnet/corefx@672d6b0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently when I added the DisposeAsync methods to the refs, I didn't actually mark the corresponding types as implementing the interface. This fixes that.
cc: @ahsonkhan