This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Use NativeLibrary.TryLoad and prefer RTLD_LAZY over RTLD_NOW #35548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am11
commented
Feb 23, 2019
|
and in case of macOS, it cancelled after two hours:
|
|
I hit retry on macOS |
danmoseley
approved these changes
Feb 26, 2019
stephentoub
approved these changes
Feb 26, 2019
vcsjones
added a commit
to vcsjones/corefx
that referenced
this pull request
Apr 28, 2020
…tnet#35548) * Support unknown critical extensions on macOS. If a certificate contains an unprocessable critical extension in a certificate, map the "CriticalExtensions" status to HasNotSupportedCriticalExtension instead of throwing an exception. * Ignore WeakSignature chain status on macOS. X509Chain on Windows will not check for modern signatures, so we will let macOS do the same thing.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…corefx#35548) * Use NativeLibrary.TryLoad in ODBC test * Use RTLD_LAZY instead of RTLD_NOW * Add missing using statement * More RTLD_NOW -> RTLD_LAZY * Remove unused RTLD_NOW constant * Use NativeLibrary.TryLoad instead of P/Invoke dlopen * Inline method body in property * Add fallback for netcoreapp2x and below * Reduce visibility of const Commit migrated from dotnet/corefx@863b9bf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use:
NativeLibrary.TryLoadin few test helpersRTLD_LAZYinstead ofRTLD_NOWRelated to: #34633