This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[master] Update dependencies from dotnet/arcade #36103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…312.7 This change updates the following dependencies - Microsoft.DotNet.ApiCompat - 1.0.0-beta.19162.7 - Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19162.7 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19162.7 - Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19162.7 - Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19162.7 - Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19162.7 - Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19162.7 - Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19162.7 - Microsoft.DotNet.GenAPI - 1.0.0-beta.19162.7 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19162.7 - Microsoft.DotNet.SourceRewriter - 1.0.0-beta.19162.7 - Microsoft.DotNet.GenFacades - 1.0.0-beta.19162.7
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
@mmitche, @safern, I don't know where the problem stems from, but all legs are failing with errors like this: |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
@JohnTortugo Is this related to the release pipeline work? |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
I don't think it is. Looks more something related to packaging. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
@ericstj and I just took a look, it seems what it broke it was this change: dotnet/arcade#2091 because it bumped the NuGet version to a greatest version of what MSBuild depends on. So basically this is exposing an MSBuild bug that doesn't let you use newer versions of the assemblies that they directly depend on. I guess the right direction is to close until that change in arcade is reverted or we find a workaround to not hit these issues. @ericstj is opening an issue in MSBuild and we'll follow up with the arcade changes. |
|
@tmat for corefx's purposes I think using 4.9.2 would be enough, but I don't know for other repos. Would you mind jumping on this? |
|
@safern Well, we need that change to generate correct license metadata to the packages. Which MSBuild version are we talking about? Can we use newer msbuild? |
4.9.2 has the required properties needed to generate the correct license metadata. We're currently using sdk: 2.2.103 which has MSBuild 15.9.2 -- if we bump the SDK to 3.0 we would be forcing people to install that SDK globally for VS to work for their development, which I guess we don't want to enforce now. |
|
Ok, if 4.9.2 works then feel free to change the version to 4.9.2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Updates from https://github.com/dotnet/arcade
Updates from https://github.com/dotnet/arcade