[master] Update dependencies from dotnet/coreclr

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/coreclr

• Build: 20190328.73
• Date Produced: 3/29/2019 12:57 AM
• Commit: ffe8a33
• Branch: refs/heads/master
• Updates:
  • Microsoft.NET.Sdk.IL -> 3.0.0-preview4-27528-73
  • Microsoft.NETCore.ILAsm -> 3.0.0-preview4-27528-73
  • Microsoft.NETCore.Runtime.CoreCLR -> 3.0.0-preview4-27528-73

From https://github.com/dotnet/coreclr

• Build: 20190329.71
• Date Produced: 3/29/2019 12:55 PM
• Commit: dc0d072
• Branch: refs/heads/master
• Updates:
  • Microsoft.NET.Sdk.IL -> 3.0.0-preview4-27529-71
  • Microsoft.NETCore.ILAsm -> 3.0.0-preview4-27529-71
  • Microsoft.NETCore.Runtime.CoreCLR -> 3.0.0-preview4-27529-71

From https://github.com/dotnet/coreclr

• Build: 20190329.71
• Date Produced: 3/29/2019 12:55 PM
• Commit: dc0d072
• Branch: refs/heads/master
• Updates:
  • Microsoft.NET.Sdk.IL -> 3.0.0-preview4-27529-71
  • Microsoft.NETCore.ILAsm -> 3.0.0-preview4-27529-71
  • Microsoft.NETCore.Runtime.CoreCLR -> 3.0.0-preview4-27529-71

From https://github.com/dotnet/coreclr

• Build: 20190331.71
• Date Produced: 3/31/2019 12:58 PM
• Commit: 8993ac6
• Branch: refs/heads/master
• Updates:
  • Microsoft.NET.Sdk.IL -> 3.0.0-preview4-27531-71
  • Microsoft.NETCore.ILAsm -> 3.0.0-preview4-27531-71
  • Microsoft.NETCore.Runtime.CoreCLR -> 3.0.0-preview4-27531-71

From https://github.com/dotnet/coreclr

• Build: 20190401.72
• Date Produced: 4/2/2019 12:41 AM
• Commit: 5cd9a8d
• Branch: refs/heads/master
• Updates:
  • Microsoft.NET.Sdk.IL -> 3.0.0-preview4-27601-72
  • Microsoft.NETCore.ILAsm -> 3.0.0-preview4-27601-72
  • Microsoft.NETCore.Runtime.CoreCLR -> 3.0.0-preview4-27601-72

From https://github.com/dotnet/coreclr

• Build: 20190402.72
• Date Produced: 4/3/2019 12:44 AM
• Commit: 722a222
• Branch: refs/heads/master
• Updates:
  • Microsoft.NET.Sdk.IL -> 3.0.0-preview4-27602-72
  • Microsoft.NETCore.ILAsm -> 3.0.0-preview4-27602-72
  • Microsoft.NETCore.Runtime.CoreCLR -> 3.0.0-preview4-27602-72

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux x64_Release), corefx-ci (Windows x86_Release)

[danmoseley]

Linux is just Fedora 27 and can be ignored.

https://mc.dot.net/#/user/dotnet-bot/pr~2Fdotnet~2Fcorefx~2Frefs~2Fpull~2F36480~2Fmerge/test~2Ffunctional~2Fcli~2F/20190329.4

Windows is fishier. Several failures in serialization tests. In the XML ones, this is throwing System.ArgumentException : An item with the same key has already been added. Key: SerializationTypes.StructNotSerializable

            WithStructs = new Dictionary<StructNotSerializable, StructNotSerializable>();
            WithStructs.Add(new StructNotSerializable() { value = 10 }, new StructNotSerializable() { value = 12 });
            WithStructs.Add(new StructNotSerializable() { value = int.MaxValue }, new StructNotSerializable() { value = int.MinValue });

that type definition

    public struct StructNotSerializable
    {
        public int value;

        public override int GetHashCode()
        {
            return value;
        }
    }

The default implementation of ValueType.Equals() should not consider these equal! I don't see a change in ValueType.cs though.

@jkotas thoughts?

[danmoseley]

The JSON ones look likely the same cause.

[danmoseley]

Any why didn't these tests fail in CoreCLR...

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux x64_Release), corefx-ci (Windows x86_Release)

[jkotas]

Any why didn't these tests fail in CoreCLR...

This is failing on x86 only. We do not run CoreFX on x86 in CoreCLR CI today. Fixing that is on the list of coverage tweaks that I have talked with @RussKeldorph .

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux x64_Release), corefx-ci (Windows x86_Release)

[RussKeldorph]

@briansull FYI

[jkotas]

The default implementation of ValueType.Equals() should not consider these equal! I don't see a change in ValueType.cs though.
@jkotas thoughts?

Given that this fails on x86 only, this break is likely introduced by dotnet/coreclr#22255 . @CarolEidt Could you please take a look? (Let me know if you need help with isolating a small repro.)

[CarolEidt]

@jkotas - I'm tracking down another test failure due to dotnet/coreclr#22255. This may or may not be the same root cause, but if you have some time to get a small repro, it would be greatly appreciated.

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux x64_Release), corefx-ci (Windows x86_Release)

[jkotas]

@CarolEidt Here is a small repro:

Repros on x86 only

Actual result: 0 15
Expected result: 12 15

using System;
using System.Collections.Generic;

public struct TestStruct
{
    public int value1;

    public override string ToString()
    {
        return this.value1.ToString();
    }
}

class Test
{
    public static Dictionary<TestStruct, TestStruct> StructKeyValue
    {
        get
        {
            return new Dictionary<TestStruct, TestStruct>()
            {
                {
                    new TestStruct(){value1 = 12}, new TestStruct(){value1 = 15}
                }
            };
        }
    }

    static void Main()
    {
        foreach (var e in StructKeyValue) { Console.WriteLine(e.Key.ToString() + " " + e.Value.ToString()); }
    }
}

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows x86_Release), corefx-ci (Linux arm64_Release)

[CarolEidt]

Thanks @jkotas for the repro test case - I've verified that it's fixed with my fix for https://github.com/dotnet/coreclr/issues/23545, and have added that test case to the PR (dotnet/coreclr#23570)

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows x86_Release)

[CarolEidt]

The repro case that @jkotas provided has been fixed with dotnet/coreclr#23570

[dotnet-maestro]

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

• ✔️ All Checks Successful Succeeded - Successful checks: license/cla, WIP

[stephentoub]

Conflicts. Closing.