This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Contextual reflection #36845
Merged
Contextual reflection #36845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdmaclea
added
area-System.Runtime
blocked
sdmaclea
force-pushed
the
ContextualReflection
branch
from
985b2fa to
59c4714
Compare
|
The failing unit tests should be fixed in master now. Rebase and you should see CI go green. |
sdmaclea
force-pushed
the
ContextualReflection
branch
from
59c4714 to
18e7828
Compare
|
Is this what we ended up calling the Current property? |
|
@davidfowl This was the name chosen in the API review. Yes. |
|
Bizzare, I won't even ask. Is it only an async local? Or does this set the state for all loads? |
|
@davidfowl It is an AsyncLocal. It should follow AsyncLocal semantics which means it should be inherited when starting threads and tasks, but independent after. |
|
Hmm, I'll try this out to see if it works for the hot reload scenario I'm working on. I'm not sure it will but we'll see. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Add ContextualReflection facade * Update ApiCompatBaseline.uapaot Commit migrated from dotnet/corefx@3e2be47
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the AssemblyLoadContext contextual reflection Façade.
Fixes #36236 API Review
I'll add tests in a separate PR.
Includes squash/rebase of #36816 to get new coreclr bits...