This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
SqlClient add concurrent load tests #37027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabh500
reviewed
Apr 19, 2019
src/System.Data.SqlClient/tests/ManualTests/ProviderAgnostic/ReaderTest/ReaderTest.cs
Outdated
Show resolved
Hide resolved
saurabh500
reviewed
Apr 19, 2019
src/System.Data.SqlClient/tests/ManualTests/ProviderAgnostic/ReaderTest/ReaderTest.cs
Outdated
Show resolved
Hide resolved
saurabh500
reviewed
Apr 19, 2019
src/System.Data.SqlClient/tests/ManualTests/ProviderAgnostic/ReaderTest/ReaderTest.cs
Outdated
Show resolved
Hide resolved
saurabh500
reviewed
Apr 19, 2019
src/System.Data.SqlClient/tests/ManualTests/ProviderAgnostic/ReaderTest/ReaderTest.cs
Outdated
Show resolved
Hide resolved
saurabh500
reviewed
Apr 19, 2019
src/System.Data.SqlClient/tests/ManualTests/ProviderAgnostic/ReaderTest/ReaderTest.cs
Outdated
Show resolved
Hide resolved
saurabh500
reviewed
Apr 19, 2019
src/System.Data.SqlClient/tests/ManualTests/ProviderAgnostic/ReaderTest/ReaderTest.cs
Outdated
Show resolved
Hide resolved
saurabh500
approved these changes
Apr 22, 2019
|
@afsanehr will put this through the CI and merge. |
|
Successfully passed the tests. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…tload SqlClient add concurrent load tests Commit migrated from dotnet/corefx@a3ab91e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When investigating a concurrency bug I had introduced in SqlEnvChange it was suggested that the DataAccessPerformance benchmarking project that I had been using could be transformed into a test to make sure coverage of continuous concurrent loading was covered in case similar issues are added again. This PR adds those tests.
There are two tests, one each for sync and async. Each tests will warmup for 1 second, execute for 60 seconds and create tasks over 4x the physical core count to ensure that there is contention. The data being read is from the sample Northwind database already used in the manual test project and is similar in shape and types to the Fortunes test of the original. The tests have been added in ProviderAgnostic\ReaderTest as TestConcurrentLoadSync and TestConcurrentLoadAsync because they can be re-used by other providers simply by changing the factory parameter.
/cc @afsanehr, @tarikulsabbir, @Gary-Zh , @David-Engel, @saurabh500
this should unblock #36664 and #36108