This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fixing expression interpreter for NegateChecked overflow behavior #3754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note this also removes a few Negate instructions for arithmetic types that are not supported through the factory methods anyway. |
Member
|
LGTM. |
Member
|
looks like this needs rebasing |
Contributor
Author
|
Should be good to go now. |
VSadov
added a commit
that referenced
this pull request
Oct 9, 2015
Fixing expression interpreter for NegateChecked overflow behavior
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fixing expression interpreter for NegateChecked overflow behavior Commit migrated from dotnet/corefx@d1eba76
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #3750.
cc @VSadov