This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Amortize WebSocket.EnsureBufferContainsAsync calls #39455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Holding until .NET Core 3.0 fork. |
davidsh
added
* NO MERGE *
benaadams
force-pushed
the
websocket
branch
3 times, most recently
from
2879ebd to
74a13ff
Compare
stephentoub
removed
* NO MERGE *
stephentoub
reviewed
Jul 17, 2019
src/System.Net.WebSockets.WebSocketProtocol/ref/System.Net.WebSockets.WebSocketProtocol.csproj
Show resolved
Hide resolved
src/System.Net.WebSockets.WebSocketProtocol/ref/System.Net.WebSockets.WebSocketProtocol.csproj
Show resolved
Hide resolved
|
Changes applied. CI not triggered though. |
|
Rebased to trigger CI; didn't seem to work |
|
/azp run corefx-ci |
|
😢 |
|
/azp run |
|
Raised issue for CI not running https://github.com/dotnet/corefx/issues/39593 |
|
🎉 |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
stephentoub
reviewed
Jul 22, 2019
|
@wfurt @davidsh @stephentoub should be good now |
|
Probably want to hold on this for now until dotnet/coreclr#26310 is evaluated |
stephentoub
added
the
* NO MERGE *
|
Thanks, @benaadams. I'm going to close this under the assumption now that dotnet/coreclr#26310 is going in in some form. We can keep this in the back of our minds though in case we end up backing that out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre
Post
Contributes to https://github.com/dotnet/corefx/issues/39256
Ignore ident changes https://github.com/dotnet/corefx/pull/39455/files?w=1
/cc @stephentoub @davidsh