This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Enable partial package build during source build #40061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericstj
requested review from
nguerrera,
dseefeld,
ViktorHofer,
dagood and
joperezr
ViktorHofer
approved these changes
Aug 7, 2019
ericstj
force-pushed
the
sourceBuildSomePackages
branch
from
797dd2d to
5bce9ae
Compare
ericstj
added a commit
to ericstj/corefx
that referenced
this pull request
Aug 7, 2019
wtgodbe
pushed a commit
that referenced
this pull request
Aug 8, 2019
joperezr
reviewed
Aug 8, 2019
| @@ -1,6 +1,10 @@ | |||
| <Project DefaultTargets="Build"> | |||
| <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), Directory.Build.props))\Directory.Build.props" /> | |||
|
|
|||
| <PropertyGroup Condition="'$(DotNetBuildFromSource)' == 'true'"> | |||
| <AdditionalBuildConfigurations>$(AdditionalBuildConfigurations);netstandard-$(ConfigurationGroup)</AdditionalBuildConfigurations> | |||
There was a problem hiding this comment.
I thought we already do this but I guess that was only for the refs.
There was a problem hiding this comment.
Yeah, we need it for the refs so that we can build libs that target netstandard. Normally we don't need it for the libs for netstandard as there isn't such a thing as a runnable netstandard layout so having a "complete" set of netstandard libs doesn't have a scenario for our normal builds. Here it is handy because it is a shortcut for additional libs which we know we can build in source-build that will help flesh out the source build packages.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns on package build during source build and builds all the library packages.
Packages omit any library build that wasn't part of source build, and do so in a way that won't change nuget resolution. We also include assets that might only build during source build (eg: a netcoreapp3.0 targeting library when the package might only contain a netcoreapp2.0 targeting version).
This should satisfy all up-stack dependencies for netcoreapp3.0 on corefx produced packages.
The SDK also has some dependencies on desktop assets that are not covered by this, due to the packages shipping a netstandard2.0 asset but having a "better" netcoreapp3.0 specific asset that will be built. To ensure we build the netstandard asset I made sure that we build the best configurations for both netcoreapp and netstandard for all src projects.
Fixes #39787 #39793