Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Revert "Enable build on hosted arm64" #40427

Closed
wants to merge 1 commit into from

Conversation

joperezr
Copy link
Member

Reverts #40311

FYI @ViktorHofer @wfurt @omajid @jozkee

I'm reverting this PR as it broke our VS scenario. Basically by default, we always built targeting x64, but because VS runs as an x86 process, we are now picking a different configuration when building inside VS. This is causing for all of our tests to break, as now you won't be able to build and run tests from VS. I'm not sure what was the main reasoning behind the original change, since I assumed that you could achieve the same thing by simply passing in ArchGroup when calling ./build.sh and that would allow you to control how to build in a hosted environment. Anyways, I'm revering this now in order to unblock devs broken trying to run tests in VS now, @omajid but feel free to submit a new PR taking this problem in consideration.

@omajid
Copy link
Member

omajid commented Aug 19, 2019

Duplicate of #40424 ?

@joperezr
Copy link
Member Author

You are right. Closing.

@omajid
Copy link
Member

omajid commented Aug 20, 2019

I am thinking of a fix for the VS issue. Some thoughts:

I'm not sure what was the main reasoning behind the original change, since I assumed that you could achieve the same thing by simply passing in ArchGroup when calling ./build.sh and that would allow you to control how to build in a hosted environment.

When I build a .NET Core component on linux-x64, I just do ./build.sh. I was hoping that things could be just as simple on other platforms. On linux-arm64, I would like to just do ./build.sh and have everything work out of the box without having to worry about runtime ids, architecture names or property names.

Is that an unrealistic goal?

Basically by default, we always built targeting x64, but because VS runs as an x86 process, we are now picking a different configuration when building inside VS.

VS is an x86-only process, right? Not x64, and not arm64, right? Would it make sense to assume "if we are building in Visual Studio, set the architecture to x64 otherwise use the current processor's architecture"?

@wfurt
Copy link
Member

wfurt commented Aug 20, 2019

I agree with @omajid that it would be nice if ./build.sh just work. In ideal case, all scripted cases can be parametrized but defaults for developers should be as simple as possible.

It would be ideal if VS can always be explicit about architecture. But if that is difficult, I think we can always handle it as special case e.g. Windows x86 vs x64.

@omajid
Copy link
Member

omajid commented Aug 20, 2019

Here's another attempt at this: #40453

I dont have access to VS to verify this, unfortunately.

@ViktorHofer ViktorHofer deleted the revert-40311-build-on-arm64 branch August 21, 2019 17:34
@karelz karelz added this to the 5.0 milestone Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants