This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #40311
FYI @ViktorHofer @wfurt @omajid @jozkee
I'm reverting this PR as it broke our VS scenario. Basically by default, we always built targeting x64, but because VS runs as an x86 process, we are now picking a different configuration when building inside VS. This is causing for all of our tests to break, as now you won't be able to build and run tests from VS. I'm not sure what was the main reasoning behind the original change, since I assumed that you could achieve the same thing by simply passing in ArchGroup when calling ./build.sh and that would allow you to control how to build in a hosted environment. Anyways, I'm revering this now in order to unblock devs broken trying to run tests in VS now, @omajid but feel free to submit a new PR taking this problem in consideration.