This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Nullability annotations for System.Console #41161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to: #40623
maryamariyan
commented
Sep 17, 2019
safern
reviewed
Sep 17, 2019
safern
reviewed
Sep 17, 2019
safern
approved these changes
Sep 17, 2019
buyaa-n
reviewed
Sep 17, 2019
buyaa-n
reviewed
Sep 17, 2019
stephentoub
reviewed
Sep 18, 2019
| @@ -81,12 +82,12 @@ public static Encoding OutputEncoding | |||
| // s_out reinitialize the console code page. | |||
| if (Volatile.Read(ref s_out) != null && !s_isOutTextWriterRedirected) | |||
| { | |||
| s_out.Flush(); | |||
| s_out!.Flush(); | |||
There was a problem hiding this comment.
This ! is correct, but a little unfortunate. @jcouv, our use of [NotNullIfNotNull] on Volatile.Read was intended to cover cases like this, but it falls short because it's only one directional: the compiler can know that the return value is not null if s_out is not null, but it can't then also infer that s_out is not null if the return value is not null.
maryamariyan
commented
Sep 18, 2019
buyaa-n
reviewed
Sep 18, 2019
buyaa-n
reviewed
Sep 18, 2019
buyaa-n
reviewed
Sep 18, 2019
buyaa-n
reviewed
Sep 18, 2019
buyaa-n
reviewed
Sep 18, 2019
buyaa-n
reviewed
Sep 18, 2019
buyaa-n
reviewed
Sep 18, 2019
maryamariyan
force-pushed
the
sys-console-null
branch
from
6bb636e to
60d9a30
Compare
danmoseley
reviewed
Sep 19, 2019
This reverts commit fb4cd4b.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Contributes to: dotnet/corefx#40623 Commit migrated from dotnet/corefx@19b304f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to: #40623
cc: @safern @buyaa-n