This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Update experimental IsShipping and block stable properties #41513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per our email, I don't really know the finer details of how the build / packaging system works. But I'm supportive of getting the experimental packages available on NuGet. |
safern
added a commit
to safern/corefx
that referenced
this pull request
Oct 3, 2019
safern
added a commit
to safern/corefx
that referenced
this pull request
Oct 3, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I moved to use the arcade
IsShippingconvention, I disabled publishing to NuGet.org for experimental packages. The reasoning of that, is because anything mark as non-shipping, will not make it to NuGet.org.So we need to mark them only as
IsShippingAssembly=falseso that theAssemblyInformationalVersionin metadata isn't stable whenever we ship stable. Also, mark them asSuppressFinalPackageVersionso that it doesn't produce a stable version of the package whenever we build those.SuppressFinalPackageVersionis the newBlockStableproperty: dotnet/arcade#1213This will need to go into 3.1 in order to ship the experimental packages to NuGet.org.
FYI: @GrabYourPitchforks @tannergooding
cc: @danmosemsft