initial support for serial port on FreeBSD #42519

wfurt · 2019-11-10T04:38:02Z

I did some testing while back when I was working on Serial port but that never made it to product. FreeBSD has standard Unix termios and everything should just work.
For port names, I used guidance from https://www.freebsd.org/doc/en_US.ISO8859-1/books/faq/serial.html

minimal set of tests will pass

  /usr/home/furt/git/wfurt-corefx/artifacts/bin/testhost/netcoreapp-FreeBSD-Debug-x64/dotnet exec --runtimeconfig System.IO.Ports.Tests.runtimeconfig.json xunit.console.dll System.IO.Ports.Tests.dll -xml testResults.xml -nologo -notrait category=nonnetcoreapptests -notrait category=nonfreebsdtests -notrait category=OuterLoop -notrait category=failing
  popd
  ===========================================================================================================
  /usr/home/furt/git/wfurt-corefx/artifacts/bin/System.IO.Ports.Tests/netcoreapp-FreeBSD-Debug ~/git/wfurt-corefx/src/System.IO.Ports/tests
    Discovering: System.IO.Ports.Tests (method display = ClassAndMethod, method display options = None)
  Installed ports : /dev/cuau0
  Openable ports  : /dev/cuau0
  No support hardware - not using serial ports
  First available port name  :
  Second available port name :
  Loopback port name         :
  NullModem present          : False
    Discovered:  System.IO.Ports.Tests (found 954 of 978 test cases)
    Starting:    System.IO.Ports.Tests (parallel test collections = on, max threads = 2)
...
...
    Finished:    System.IO.Ports.Tests
  === TEST EXECUTION SUMMARY ===
     System.IO.Ports.Tests  Total: 954, Errors: 0, Failed: 0, Skipped: 832, Time: 0.444s
  ~/git/wfurt-corefx/src/System.IO.Ports/tests
  ----- end Sat Nov 9 20:35:33 PST 2019 ----- exit code 0 ----------------------------------------------------------
  exit code 0 means Exited Successfully

…d_serial

stephentoub · 2019-11-10T13:51:11Z

src/System.IO.Ports/src/System.IO.Ports.csproj

@@ -2,12 +2,12 @@
  <PropertyGroup>
    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
    <IsPartialFacadeAssembly Condition="'$(TargetsNetFx)' == 'true'">true</IsPartialFacadeAssembly>
-    <GeneratePlatformNotSupportedAssemblyMessage Condition="'$(TargetsNetStandard)' == 'true' and '$(TargetsWindows)' != 'true' and '$(TargetsLinux)' != 'true' and '$(TargetsOSX)' != 'true'">SR.PlatformNotSupported_IOPorts</GeneratePlatformNotSupportedAssemblyMessage>
+    <GeneratePlatformNotSupportedAssemblyMessage Condition="'$(TargetsNetStandard)' == 'true' and '$(TargetsWindows)' != 'true' and '$(TargetsLinux)' != 'true' and '$(TargetsOSX)' != 'true' and '$(TargetsFreeBSD)' != 'true'">SR.PlatformNotSupported_IOPorts</GeneratePlatformNotSupportedAssemblyMessage>


What configuration does this still apply to?

I think the UnknownUnix was originally there as stub for new platforms. Web assembly may fall into this bucket now. cc @safern

Not necessary for this PR, but this condition is getting a bit unwieldy... send like it could be better to start listing what should have this done rather than what shouldn't, or find some other way to simplify it.
cc: @krwq

Currently this project (with this change) has the following configurations:

corefx/src/System.IO.Ports/src/Configurations.props

Lines 3 to 14 in 6e190fe

<PackageConfigurations>

netstandard2.0-Windows_NT;

netstandard2.0-Linux;

netstandard2.0-OSX;

netstandard2.0-FreeBSD;

netstandard2.0;

net461-Windows_NT;

</PackageConfigurations>

<BuildConfigurations>

$(PackageConfigurations)

netfx-Windows_NT;

</BuildConfigurations>

If we look at the os groups definitions:

corefx/eng/configurations/osgroups.props

Lines 13 to 43 in 6e190fe

<OSGroups Include="Linux">

<Imports>Unix</Imports>

<TargetsUnix>true</TargetsUnix>

<TargetsLinux>true</TargetsLinux>

<PackageTargetRuntime>linux</PackageTargetRuntime>

</OSGroups>

<OSGroups Include="OSX">

<Imports>Unix</Imports>

<TargetsUnix>true</TargetsUnix>

<TargetsOSX>true</TargetsOSX>

<PackageTargetRuntime>osx</PackageTargetRuntime>

</OSGroups>

<OSGroups Include="FreeBSD">

<Imports>Unix</Imports>

<TargetsUnix>true</TargetsUnix>

<TargetsFreeBSD>true</TargetsFreeBSD>

<PackageTargetRuntime>freebsd</PackageTargetRuntime>

</OSGroups>

<OSGroups Include="NetBSD">

<Imports>Unix</Imports>

<TargetsUnix>true</TargetsUnix>

<TargetsNetBSD>true</TargetsNetBSD>

<PackageTargetRuntime>netbsd</PackageTargetRuntime>

</OSGroups>

<OSGroups Include="WebAssembly">



<Imports>Linux</Imports>

<TargetsLinux>true</TargetsLinux>

<TargetsWebAssembly>true</TargetsWebAssembly>

</OSGroups>

So basically this condition applies for AnyOS which is the netstandard2.0 OS agnostic build configuration. We could update this condition to be:

'$(TargetsNetStandard)' == 'true' and '$(OSGroup)' == 'AnyOS'

Web assembly may fall into this bucket now

Not really. The way WebAssembly is hooked up it will use the netstandard2.0-Linux configuration (for now) we plan on updating it to fall into the Unix one.

stephentoub · 2019-11-10T13:51:35Z

src/System.IO.Ports/src/System.IO.Ports.csproj

    <DefineConstants>$(DefineConstants);NOSPAN</DefineConstants>
    <IncludeDllSafeSearchPathAttribute>true</IncludeDllSafeSearchPathAttribute>
    <Configurations>net461-Windows_NT-Debug;net461-Windows_NT-Release;netfx-Windows_NT-Debug;netfx-Windows_NT-Release;netstandard2.0-Debug;netstandard2.0-Linux-Debug;netstandard2.0-Linux-Release;netstandard2.0-OSX-Debug;netstandard2.0-OSX-Release;netstandard2.0-Release;netstandard2.0-Windows_NT-Debug;netstandard2.0-Windows_NT-Release</Configurations>
  </PropertyGroup>
-  <ItemGroup Condition="'$(TargetsNetFx)' != 'true' and ('$(TargetsWindows)' == 'true' or '$(TargetsLinux)' == 'true' or '$(TargetsOSX)' == 'true')">
+  <ItemGroup Condition="'$(TargetsNetFx)' != 'true' and ('$(TargetsWindows)' == 'true' or '$(TargetsLinux)' == 'true' or '$(TargetsOSX)' == 'true' or '$(TargetsFreeBSD)' == 'true')">


Same question

stephentoub · 2019-11-10T13:58:25Z

src/System.IO.Ports/tests/Support/PortHelper.cs

@@ -22,7 +22,7 @@ public class PortHelper

        public static string[] GetPorts()
        {
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux) || RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux) || RuntimeInformation.IsOSPlatform(OSPlatform.OSX) || RuntimeInformation.IsOSPlatform(OSPlatform.FreeBSD))


!IsWindows?

safern · 2019-11-13T21:51:24Z

src/System.IO.Ports/src/System.IO.Ports.csproj

    <DefineConstants>$(DefineConstants);NOSPAN</DefineConstants>
    <IncludeDllSafeSearchPathAttribute>true</IncludeDllSafeSearchPathAttribute>
    <Configurations>net461-Windows_NT-Debug;net461-Windows_NT-Release;netfx-Windows_NT-Debug;netfx-Windows_NT-Release;netstandard2.0-Debug;netstandard2.0-Linux-Debug;netstandard2.0-Linux-Release;netstandard2.0-OSX-Debug;netstandard2.0-OSX-Release;netstandard2.0-Release;netstandard2.0-Windows_NT-Debug;netstandard2.0-Windows_NT-Release</Configurations>
  </PropertyGroup>
-  <ItemGroup Condition="'$(TargetsNetFx)' != 'true' and ('$(TargetsWindows)' == 'true' or '$(TargetsLinux)' == 'true' or '$(TargetsOSX)' == 'true')">
+  <ItemGroup Condition="'$(TargetsNetStandard)' == 'true'">


I think this condition is missing and '$(OSGroup)' != 'AnyOS', right?

I was looking at it and It did not seems like that was needed.
I guess I missed something but it seems like we want this every-time except netfx.

netstandard will generate a platform not supported assembly when OSGroup == AnyOS so that's the netstandard2.0 rid-less build configuration in configurations.props.

That's why the all configurations build is failing, because members will be defined twice, by the auto generated code to throw platform not supported and by these compile items.

krwq · 2019-11-13T21:53:41Z

src/System.IO.Ports/src/System/IO/Ports/SerialPort.FreeBSD.cs

+        {
+            List<string> ports = new List<string>();
+
+            foreach (string name in Directory.GetFiles("/dev", "ttyd*"))


would it make sense to merge this with Unix logic?

krwq

LGTM code wise (or nothing blocking considering repo merge)

wfurt · 2019-11-14T00:52:50Z

Failure in System.Net.Security is unrelated (#37899)

ViktorHofer · 2019-11-14T15:29:41Z

It seems this broke the build in coreclr. The System.IO.Ports package depends on the runtime.freebsd-x64.runtime.native.System.IO.Ports package which isn't uploaded anywhere?!

wfurt · 2019-11-14T16:08:52Z

I'm not sure why that got missed. an you revert the build change @ViktorHofer?
I think it should be enough to take it out of Configurations.props.

ViktorHofer · 2019-11-14T16:22:15Z

I'm not reverting it right now as we don't publish packages in the new repo for some time which means I can simply downgrade the used package version of corefx's transport package.

ViktorHofer · 2019-11-14T16:22:34Z

If there's a straightforward fix, you can submit it on Monday when we open the repo internally.

safern · 2019-11-14T16:27:55Z

I'm not sure why that got missed. an you revert the build change @ViktorHofer?

In order for the runtime.freebsd-x64.runtime.native.System.IO.Ports we would need to build corefx either on FreeBSD, or have a leg where we build with RuntimeOS=freebsd.

wfurt · 2019-11-14T17:24:22Z

So far this was always independent and it would need FreeBSD packages only when built on FreeBSD. I'm not quite sure why this is different. I'm skeptical we will have FreeBSD leg any time soon.

wfurt added 2 commits November 9, 2019 20:12

initial support for serial port on FreeBSD

2e8a2f1

adjust port name selection

1dfeb41

wfurt added area-System.IO os-freebsd FreeBSD OS labels Nov 10, 2019

wfurt requested review from krwq and stephentoub November 10, 2019 04:38

wfurt self-assigned this Nov 10, 2019

wfurt added 2 commits November 9, 2019 21:54

update packaging

6e190fe

Merge branch 'master' of https://github.com/dotnet/corefx into freebs…

8cfe938

…d_serial

stephentoub approved these changes Nov 10, 2019

View reviewed changes

wfurt added 3 commits November 13, 2019 10:42

feedback from review

5538883

fix PortHelper

dc69647

update include with AnyOS

e6cda7b

safern reviewed Nov 13, 2019

View reviewed changes

krwq reviewed Nov 13, 2019

View reviewed changes

krwq approved these changes Nov 13, 2019

View reviewed changes

wfurt merged commit 7a4822f into dotnet:master Nov 14, 2019

wfurt deleted the freebsd_serial branch November 14, 2019 00:53

karelz added this to the 5.0 milestone Dec 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

initial support for serial port on FreeBSD #42519

initial support for serial port on FreeBSD #42519

wfurt commented Nov 10, 2019

stephentoub Nov 10, 2019

wfurt Nov 11, 2019

stephentoub Nov 11, 2019

safern Nov 11, 2019 •

edited

Loading

stephentoub Nov 10, 2019

stephentoub Nov 10, 2019

safern Nov 13, 2019

wfurt Nov 13, 2019

safern Nov 13, 2019

krwq Nov 13, 2019

krwq left a comment

wfurt commented Nov 14, 2019

ViktorHofer commented Nov 14, 2019

wfurt commented Nov 14, 2019

ViktorHofer commented Nov 14, 2019

ViktorHofer commented Nov 14, 2019 •

edited

Loading

safern commented Nov 14, 2019

wfurt commented Nov 14, 2019

	<PackageConfigurations>
	netstandard2.0-Windows_NT;
	netstandard2.0-Linux;
	netstandard2.0-OSX;
	netstandard2.0-FreeBSD;
	netstandard2.0;
	net461-Windows_NT;
	</PackageConfigurations>
	<BuildConfigurations>
	$(PackageConfigurations)
	netfx-Windows_NT;
	</BuildConfigurations>

	<OSGroups Include="Linux">
	<Imports>Unix</Imports>
	<TargetsUnix>true</TargetsUnix>
	<TargetsLinux>true</TargetsLinux>
	<PackageTargetRuntime>linux</PackageTargetRuntime>
	</OSGroups>
	<OSGroups Include="OSX">
	<Imports>Unix</Imports>
	<TargetsUnix>true</TargetsUnix>
	<TargetsOSX>true</TargetsOSX>
	<PackageTargetRuntime>osx</PackageTargetRuntime>
	</OSGroups>
	<OSGroups Include="FreeBSD">
	<Imports>Unix</Imports>
	<TargetsUnix>true</TargetsUnix>
	<TargetsFreeBSD>true</TargetsFreeBSD>
	<PackageTargetRuntime>freebsd</PackageTargetRuntime>
	</OSGroups>
	<OSGroups Include="NetBSD">
	<Imports>Unix</Imports>
	<TargetsUnix>true</TargetsUnix>
	<TargetsNetBSD>true</TargetsNetBSD>
	<PackageTargetRuntime>netbsd</PackageTargetRuntime>
	</OSGroups>
	<OSGroups Include="WebAssembly">
	<!-- TODO: we need to change this to import Unix instead whenever
	we want to start using managed implementation for WebAssembly -->
	<Imports>Linux</Imports>
	<TargetsLinux>true</TargetsLinux>
	<TargetsWebAssembly>true</TargetsWebAssembly>
	</OSGroups>

initial support for serial port on FreeBSD #42519

initial support for serial port on FreeBSD #42519

Conversation

wfurt commented Nov 10, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

safern Nov 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

krwq left a comment

Choose a reason for hiding this comment

wfurt commented Nov 14, 2019

ViktorHofer commented Nov 14, 2019

wfurt commented Nov 14, 2019

ViktorHofer commented Nov 14, 2019

ViktorHofer commented Nov 14, 2019 • edited Loading

safern commented Nov 14, 2019

wfurt commented Nov 14, 2019

safern Nov 11, 2019 •

edited

Loading

ViktorHofer commented Nov 14, 2019 •

edited

Loading