1) Adding support for excluding [NonSerialized] members from serialization, this is prerequisite for #2; 2) Adding support for ReadOnlyDictionary.

[SGuyGe]

@shmao @khdang @zhenlan

[justinvp]

Why is parsing this and converting it to a Dictionary even necessary? Why not a pre-parsed dictionary? e.g.:

private static readonly Dictionary<string, string[]> s_knownSerializableGenericTypes = new Dictionary<string, string[]>
{
    { "System.Collections.Generic.KeyValuePair`2", Array.Empty<string>() },
    { "System.Collections.Generic.Queue`1", new[] { "_syncRoot" } },
    { "System.Collections.Generic.Stack`1", new[] { "_syncRoot" } },
    { "System.Collections.ObjectModel.ReadOnlyCollection`1", new[] { "_syncRoot" } },
    { "System.Collections.ObjectModel.ReadOnlyDictionary`2", new[] { "_syncRoot", "_keys", "_values" } },
    { "System.Tuple`1", Array.Empty<string>() },

    ... etc. ...
};

[justinvp]

Also, why not just have a single Dictionary for both generic and non-generic types...

Then change IsKnownSerializableType to something like:

        internal static bool IsKnownSerializableType(Type type)
        {
            // Applies to known types that DCS understands how to serialize/deserialize
            //

            TypeInfo typeInfo = type.GetTypeInfo();
            string fullName = typeInfo.IsGenericType && !typeInfo.IsGenericTypeDefinition ?
                typeInfo.GetGenericTypeDefinition().FullName :
                type.FullName;

            return s_knownSerializableTypes.ContainsKey(fullName) ||
                Globals.TypeOfException.IsAssignableFrom(type);
        }

[justinvp]

Nit: for consistency, in the above two lines, new [] can be new[] (without the space between new and []).

[justinvp]

Sorry, I missed this previously: type.GetTypeInfo().IsGenericType -> typeInfo.IsGenericType

[khdang]

LGTM

[shmao]

LGTM.

[SGuyGe]

@dotnet-bot test this please

[SGuyGe]

@dotnet-bot test this please

[SGuyGe]

@dotnet-bot test this please

[weshaggard]

@dotnet-bot test Innerloop OSX Release Build and Test
@dotnet-bot test Innerloop Ubuntu Debug Build and Test