This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Cleanup Buffer tests #7614
Merged
Cleanup Buffer tests #7614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| Assert.Equal(sourceArray[i], destinationArray[i + destinationIndexOffset - sourceIndexOffset]); | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you add loops verifying that before and after the range in the destinationArray remain 0?
|
Some comments, otherwise LGTM. |
- Take advantage of xunit - Add some missing tests Contributes to #6286 Note to reviewers: I did not remove the Buffer.MemoryCopy file for the sake of combining test files into a single file. I did this because I did a major overhaul of the tests, and this suited the Buffer.cs file
|
Thanks, I addressed your comments - unfortunately I couldn't add all the extra tests you asked for, as If we want to test all inputs up to 16, I think we need to use a different non-integer primitive type |
Yes, |
Done |
|
Thanks. LGTM. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Cleanup Buffer tests - Take advantage of xunit - Add some missing tests Contributes to dotnet/corefx#6286 Commit migrated from dotnet/corefx@7f57da2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #6286
Cherry picked from #5490