Fix some named mutex tests

[kouvel]

Related to dotnet/coreclr#5030
Related to dotnet/coreclr#3422

[kouvel]

@sergiy-k @stephentoub

Flagged as [WIP] until the dependency change goes into coreclr

[stephentoub]

You might consider refactoring this a bit, e.g. (pseudo-code)

public static IEnumerable<object[]> AbandonExisting_MemberData()
{
    for (int waitType = 0; waitType < 2; waitType++) // 0 == Wait, 1 == WaitAny
    {
        yield return new object[] { null, waitType};
        yield return new object[] { Guid.NewGuid().ToString("N"), waitType };
    }
}

[Theory]
[MemberData(nameof(AbandonExisting_MemberData))]
public void AbandonExisting(string name, int waitType)
{
    using (Mutex m = new Mutex(false, name))
    {
        Task.Factory.StartNew(() => Assert.True(m.WaitOne(FailedWaitTimeout),
            CancellationToken.None, TaskCreationOptions.LongRunning, TaskScheduler.Default).Wait();
        switch (waitType)
        {
            case 0:
                Assert.Throws<AbandonedMutexException>(() => m.WaitOne(FailedWaitTimeout));
                break;
            case 1:
                AbandonedMutexException ame = Assert.Throws<AbandonedMutexException>(() => WaitHandle.WaitAny(new[] { m }, FailedWaitTimeout));
                Assert.Equal(0, ame.MutexIndex);
                Assert.Equal(m, ame.Mutex);
                break;
        }
    }
}

[kouvel]

Done

[stephentoub]

Thanks for updating these (and for the Mutex implementation!)

One comment, otherwise LGTM.

We should also look at adding a cross-process test of the naming, similar in concept to https://github.com/dotnet/corefx/blob/master/src/System.Threading/tests/SemaphoreTests.cs#L281-L317 . That could be done as a separate PR if you wanted, though it might be useful here as well to help validate the CoreCLR change.

[kouvel]

I'm doing all of the cross-process testing in the PAL tests, and leaving the CoreFX tests to just do basic API-level testing (to cover the layer from the .NET API to the PAL Windows API). I'll take a closer look at the test you pointed to, and will see if I can add something similar.

[kouvel]

Looked at the test, I have tests like that in PAL tests already

[kouvel]

@dotnet-bot test this please

[kouvel]

@dotnet-bot test this please

[kouvel]

@dotnet-bot test this please

[kouvel]

@dotnet-bot test this please