This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
UserDefinedTypeDescriptor: fix type for enum vars. #5550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbaladurin
commented
Mar 15, 2018
| @@ -180,6 +180,10 @@ private uint GetVariableTypeIndex(TypeDesc type, bool needsCompleteIndex) | |||
| variableTypeIndex = GetEnumTypeIndex(type); | |||
|
|
|||
| GetTypeIndex(type, false); // Ensure regular structure record created | |||
There was a problem hiding this comment.
Why should we create record for enum structure? Seems like we doesn't use it.
There was a problem hiding this comment.
@davidwrighton This came with #3932 . Could you please take a look?
|
@jkotas PTAL |
This was referenced Mar 16, 2018
jkotas
approved these changes
Apr 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't use enum type index for enum vars. This patch fixes it.